This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Components interspacing #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 31, 2018
| return 0 | ||
| } | ||
|
|
||
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, insetForSectionAt section: Int) -> UIEdgeInsets { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 162 characters (line_length)
| return 0 | ||
| } | ||
|
|
||
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, minimumInteritemSpacingForSectionAt section: Int) -> CGFloat { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 175 characters (line_length)
| @@ -121,6 +121,18 @@ final class MessagesViewController: RocketChatViewController { | |||
|
|
|||
| extension MessagesViewController { | |||
|
|
|||
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, minimumLineSpacingForSectionAt section: Int) -> CGFloat { | |||
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 170 characters (line_length)
Codecov Report
@@ Coverage Diff @@
## feature/integrate-rc-view-controller #2269 +/- ##
=======================================================================
- Coverage 25.61% 25.6% -0.02%
=======================================================================
Files 437 437
Lines 16515 16522 +7
=======================================================================
Hits 4231 4231
- Misses 12284 12291 +7
Continue to review full report at Codecov.
|
…ketChat/Rocket.Chat.iOS into feature/components-spacing
…cket.Chat.iOS into feature/components-spacing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios