This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[NEW][RCVC] Reintroduce all shortcuts & message searching #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 9, 2018
… into update_shortcuts_code
cardoso
changed the title
cardoso
force-pushed
the
update_shortcuts_code
branch
from
bdb63b2
to
665457e
Compare
cardoso
force-pushed
the
update_shortcuts_code
branch
from
665457e
to
5188f43
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2300 +/- ##
===========================================
- Coverage 26.01% 25.98% -0.04%
===========================================
Files 433 433
Lines 15850 15876 +26
===========================================
+ Hits 4124 4125 +1
- Misses 11726 11751 +25
Continue to review full report at Codecov.
|
cardoso
force-pushed
the
update_shortcuts_code
branch
from
4201dab
to
25890c3
Compare
filipealva
approved these changes
Nov 9, 2018
There was a problem hiding this comment.
After closing the search view with the keyboard appearing the messages view insets are mistakenly adjusted to show the keyboard.
But since we have known issues with the insets I'll approve and leave this adjustment for a further PR. Anyway feel free to adjust on this PR if you want to 🤓
|
@cardoso There are some conflicts now 🙈 |
… into update_shortcuts_code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios