Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX][RCVC] Reintroduce iPad chat empty state #2301

Merged
merged 1 commit into from Nov 9, 2018
Merged

Conversation

cardoso
Copy link
Collaborator

@cardoso cardoso commented Nov 9, 2018

@RocketChat/ios

Closes #2294

@cardoso cardoso added this to the 3.2.0 milestone Nov 9, 2018
@cardoso cardoso requested a review from rafaelks November 9, 2018 18:52
func updateEmptyStateFrame() {
emptyStateImageView?.frame = view.bounds
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File Line Length Violation: File should contain 400 lines or less: currently contains 412 (file_length)

@cardoso cardoso changed the title [NEW][RCVC] Reintroduce iPad chat empty state [FIX][RCVC] Reintroduce iPad chat empty state Nov 9, 2018
Copy link
Collaborator

@filipealva filipealva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #2301 into develop will increase coverage by <.01%.
The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2301      +/-   ##
===========================================
+ Coverage    26.02%   26.02%   +<.01%     
===========================================
  Files          433      433              
  Lines        15839    15846       +7     
===========================================
+ Hits          4122     4124       +2     
- Misses       11717    11722       +5
Impacted Files Coverage Δ
...Chat/Controllers/Chat/MessagesViewController.swift 37.28% <37.5%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbafee6...d5c0b4f. Read the comment docs.

@rafaelks rafaelks added this to In progress in Cycle 11: 11/05 ~ 12/05 via automation Nov 9, 2018
@rafaelks rafaelks merged commit 3151726 into develop Nov 9, 2018
Cycle 11: 11/05 ~ 12/05 automation moved this from In progress to Done Nov 9, 2018
@rafaelks rafaelks deleted the rcvc_emptystate branch November 9, 2018 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants