This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[CHORE] Refactor scroll to bottom #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reAnimation to animate the CALayer instead of the UIView
…ggering it through a flag
houndci-bot
reviewed
Nov 16, 2018
| buttonScrollToBottom.heightAnchor.constraint(equalToConstant: buttonScrollToBottomSize), | ||
| buttonScrollToBottom.widthAnchor.constraint(equalToConstant: buttonScrollToBottomSize), | ||
| buttonScrollToBottomConstraint, | ||
| buttonScrollToBottom.trailingAnchor.constraint(equalTo: view.safeAreaLayoutGuide.trailingAnchor, constant: -15) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 123 characters (line_length)
| buttonScrollToBottom.translatesAutoresizingMaskIntoConstraints = false | ||
| view.addSubview(buttonScrollToBottom) | ||
| view.bringSubviewToFront(buttonScrollToBottom) | ||
| buttonScrollToBottomConstraint = buttonScrollToBottom.bottomAnchor.constraint(equalTo: view.bottomAnchor, constant: 50) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 127 characters (line_length)
| var keyboardHeight: CGFloat = 0 | ||
| var buttonScrollToBottomConstraint: NSLayoutConstraint! | ||
| var buttonScrollToBottomLayerY: CGFloat { | ||
| return -composerView.layer.bounds.height - buttonScrollToBottomSize / 2 - collectionView.layoutMargins.top - keyboardHeight |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 131 characters (line_length)
rafaelks
approved these changes
Nov 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
NOTE: We still have some glitches, mainly when the keyboard is dismissed, this is due to the manual changes we are doing in order to manage the insets when the keyboard is being presented.