Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX] Composer disappearing after app store review #2380

Merged
merged 2 commits into from Nov 29, 2018

Conversation

cardoso
Copy link
Collaborator

@cardoso cardoso commented Nov 28, 2018

@RocketChat/ios

Awkward solution, but seems to work well.

Closes #2329

@cardoso cardoso added this to the 3.2.0 milestone Nov 28, 2018
@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #2380 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2380      +/-   ##
===========================================
- Coverage    26.12%   26.11%   -0.01%     
===========================================
  Files          440      440              
  Lines        16498    16503       +5     
===========================================
  Hits          4310     4310              
- Misses       12188    12193       +5
Impacted Files Coverage Δ
Rocket.Chat/Views/Cells/Chat/ChatMessageCell.swift 0% <ø> (ø) ⬆️
...Chat/Controllers/Chat/MessagesViewController.swift 41.93% <ø> (ø) ⬆️
...at/MessagesViewControllerMessageCellProtocol.swift 0% <0%> (ø) ⬆️
...Chat/Views/Chat/New Chat/Cells/ReactionsCell.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2add833...6c51513. Read the comment docs.

@rafaelks rafaelks added this to In progress in Cycle 11: 11/05 ~ 12/05 via automation Nov 28, 2018
@rafaelks rafaelks merged commit 9dd1c7a into develop Nov 29, 2018
Cycle 11: 11/05 ~ 12/05 automation moved this from In progress to Done Nov 29, 2018
@rafaelks rafaelks deleted the fix/review_composer_hide.2329 branch November 29, 2018 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants