This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[IMPROVEMENT] Remove @ and add left & right spacing to mentions #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 18, 2018
Codecov Report
@@ Coverage Diff @@
## develop #2436 +/- ##
==========================================
Coverage ? 25.97%
==========================================
Files ? 447
Lines ? 16817
Branches ? 0
==========================================
Hits ? 4369
Misses ? 12448
Partials ? 0
Continue to review full report at Codecov.
|
houndci-bot
reviewed
Dec 18, 2018
Rocket.ChatTests/Extensions/NSAttributedStringExtensionsSpec.swift
Outdated
Show resolved
Hide resolved
cardoso
force-pushed
the
imp/mentions
branch
from
488b7ad
to
8007eb7
Compare
houndci-bot
reviewed
Dec 19, 2018
Rocket.ChatTests/Extensions/NSAttributedStringExtensionsSpec.swift
Outdated
Show resolved
Hide resolved
houndci-bot
reviewed
Dec 19, 2018
Rocket.ChatTests/Extensions/NSAttributedStringExtensionsSpec.swift
Outdated
Show resolved
Hide resolved
Rocket.ChatTests/Extensions/NSAttributedStringExtensionsSpec.swift
Outdated
Show resolved
Hide resolved
houndci-bot
reviewed
Dec 19, 2018
cardoso
changed the title
rafaelks
reviewed
Dec 20, 2018
| // "\u{00a0}" = non-line-breaking space character | ||
| self.insert(NSAttributedString(string: "\u{00a0}"), at: range.location) | ||
| self.insert(NSAttributedString(string: "\u{00a0}"), at: range.location + range.length + 1) | ||
| return NSRange(location: range.location, length: range.length + 2) |
rafaelks
reviewed
Dec 20, 2018
| @@ -2,7 +2,7 @@ | |||
| // NSAttributedStringExtensionsSpec.swift | |||
| // Rocket.Chat | |||
| // | |||
| // Created by Matheus Martins on 9/11/17. | |||
| // Created by Matheus Cardoso on 9/11/17. | |||
rafaelks
approved these changes
Dec 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
TODO: tests for the dangerous NSRange methods
Closes #2289