Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[IMPROVEMENT] Move message history loading to REST API #2455

Merged
merged 13 commits into from Jan 2, 2019

Conversation

cardoso
Copy link
Collaborator

@cardoso cardoso commented Dec 26, 2018

@RocketChat/ios

Closes #1516

@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #2455 into develop will increase coverage by 0.04%.
The diff coverage is 73.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2455      +/-   ##
===========================================
+ Coverage     26.2%   26.24%   +0.04%     
===========================================
  Files          455      456       +1     
  Lines        16922    16936      +14     
===========================================
+ Hits          4434     4445      +11     
- Misses       12488    12491       +3
Impacted Files Coverage Δ
Rocket.Chat/Extensions/DateExtension.swift 64.28% <ø> (ø) ⬆️
...Managers/Model/MessageManager/MessageManager.swift 23.76% <ø> (+5.71%) ⬆️
...cket.Chat/Controllers/Chat/MessagesViewModel.swift 29.75% <0%> (-0.45%) ⬇️
...et.Chat/API/Requests/Room/RoomHistoryRequest.swift 75% <75%> (ø)
Rocket.Chat/API/Clients/SubscriptionsClient.swift 65.16% <96.29%> (+5.56%) ⬆️
...anagers/Model/AuthManager/AuthManagerRecover.swift 36.36% <0%> (-60.61%) ⬇️
Rocket.Chat/Extensions/Models/AuthExtensions.swift 66.66% <0%> (-33.34%) ⬇️
...Chat/Models/Subscription/SubscriptionQueries.swift 70% <0%> (-30%) ⬇️
Rocket.Chat/Managers/PushManager.swift 24.13% <0%> (-10.35%) ⬇️
Rocket.Chat/Managers/AppManager.swift 36.47% <0%> (-4.12%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c16173...2355079. Read the comment docs.

@cardoso cardoso changed the title [WIP][IMPROVEMENT] Move message history loading to REST API [IMPROVEMENT] Move message history loading to REST API Dec 29, 2018
Copy link
Contributor

@rafaelks rafaelks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very solid, just one small thing. 👌

Copy link
Contributor

@rafaelks rafaelks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! 💯

@rafaelks rafaelks merged commit fedafd4 into develop Jan 2, 2019
@rafaelks rafaelks deleted the imp/history_rest.1516 branch January 2, 2019 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants