This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[IMPROVEMENT] Move message history loading to REST API #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 26, 2018
Codecov Report
@@ Coverage Diff @@
## develop #2455 +/- ##
===========================================
+ Coverage 26.2% 26.24% +0.04%
===========================================
Files 455 456 +1
Lines 16922 16936 +14
===========================================
+ Hits 4434 4445 +11
- Misses 12488 12491 +3
Continue to review full report at Codecov.
|
houndci-bot
reviewed
Dec 29, 2018
Rocket.Chat/API/Requests/Subscription/SubscriptionHistoryRequest.swift
Outdated
Show resolved
Hide resolved
Rocket.Chat/API/Requests/Subscription/SubscriptionHistoryRequest.swift
Outdated
Show resolved
Hide resolved
cardoso
changed the title
[WIP][IMPROVEMENT] Move message history loading to REST API
[IMPROVEMENT] Move message history loading to REST API
Dec 29, 2018
houndci-bot
reviewed
Dec 29, 2018
houndci-bot
reviewed
Dec 31, 2018
… into imp/history_rest.1516
rafaelks
approved these changes
Dec 31, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very solid, just one small thing. 👌
rafaelks
approved these changes
Jan 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! 💯
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Closes #1516