This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[FIX] Use Accelerate framework to resize UIImage in order to use much less memory for the share extension #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a low level way to optimize the resizing of UIImages and avoid using too much memory
Codecov Report
@@ Coverage Diff @@
## develop #2479 +/- ##
===========================================
- Coverage 26.29% 26.22% -0.07%
===========================================
Files 456 456
Lines 16895 16935 +40
===========================================
Hits 4442 4442
- Misses 12453 12493 +40
Continue to review full report at Codecov.
|
rafaelks
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Closes #2200
I decided to go low-level on this one, since sharing screenshots from iOS apparently sets a limit of 120MB of RAM, and the method we were using was reaching 120MB easily with any screenshot, causing the extension to crash.
More info can be found here.