Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX] Fixed issues with duplicated subscription or missing on the list #2493

Merged
merged 5 commits into from Jan 16, 2019

Conversation

rafaelks
Copy link
Contributor

@RocketChat/ios

Closes #2471
Closes #2403

@rafaelks rafaelks added this to the 3.3.0 milestone Jan 14, 2019
@rafaelks rafaelks added this to In progress in Cycle 13: 01/05 ~ 02/05 via automation Jan 14, 2019
@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #2493 into develop will decrease coverage by 0.1%.
The diff coverage is 73.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2493      +/-   ##
===========================================
- Coverage    26.39%   26.29%   -0.11%     
===========================================
  Files          456      456              
  Lines        16929    16949      +20     
===========================================
- Hits          4469     4457      -12     
- Misses       12460    12492      +32
Impacted Files Coverage Δ
...Chat/Models/Mapping/SubscriptionModelMapping.swift 87.5% <ø> (ø) ⬆️
...Controllers/Chat/ChatSections/MessageSection.swift 4.16% <ø> (ø) ⬆️
Rocket.Chat/Models/Message/UnmanagedMessage.swift 32.89% <ø> (ø) ⬆️
Rocket.Chat/API/Clients/MessagesClient.swift 58.17% <ø> (ø) ⬆️
...at/Views/Cells/Subscription/SubscriptionCell.swift 0% <0%> (ø) ⬆️
...ntrollers/Chat/MessagesViewControllerJoining.swift 70.45% <0%> (-1.64%) ⬇️
...odel/SubscriptionManager/SubscriptionManager.swift 0% <0%> (ø) ⬆️
...SubscriptionManager/SubscriptionManagerRooms.swift 26.66% <0%> (ø) ⬆️
Rocket.Chat/Models/Base/ModelHandler.swift 0% <0%> (ø) ⬆️
...Chat/Managers/Socket/Response/SocketHandlers.swift 57.5% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc7176f...8375655. Read the comment docs.

@rafaelks rafaelks changed the title [WIP][FIX] Fixed issues with duplicated subscription or missing on the list [FIX] Fixed issues with duplicated subscription or missing on the list Jan 16, 2019
@rafaelks rafaelks merged commit 497ef47 into develop Jan 16, 2019
Cycle 13: 01/05 ~ 02/05 automation moved this from In progress to Done Jan 16, 2019
@rafaelks rafaelks deleted the bug/subscription_object_missing_rid.2471 branch January 16, 2019 15:31
@JoyWang1010
Copy link

It seems not ok....

simulator screen shot - iphone x - 2019-01-17 at 10 44 26

@piepie314
Copy link

still exist some problems

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants