Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[CHORE] Remove unused code, resolve some SwiftLint warnings & suppress couple. #2517

Merged
merged 4 commits into from Jan 28, 2019

Conversation

rafaelks
Copy link
Contributor

@RocketChat/ios

@rafaelks rafaelks added this to the 3.3.0 milestone Jan 25, 2019
@rafaelks rafaelks added this to In progress in Cycle 13: 01/05 ~ 02/05 via automation Jan 25, 2019
@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #2517 into develop will increase coverage by 0.14%.
The diff coverage is 8.82%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2517      +/-   ##
===========================================
+ Coverage    26.41%   26.56%   +0.14%     
===========================================
  Files          457      456       -1     
  Lines        16950    16863      -87     
===========================================
+ Hits          4477     4479       +2     
+ Misses       12473    12384      -89
Impacted Files Coverage Δ
...ews/Chat/New Chat/Cells/BaseImageMessageCell.swift 0% <ø> (ø) ⬆️
...ews/Chat/New Chat/Cells/BaseQuoteMessageCell.swift 0% <ø> (ø) ⬆️
...cket.Chat/Controllers/Chat/MessagesViewModel.swift 29.75% <ø> (ø) ⬆️
...ket.Chat/Views/Cells/Hints/TextHintLabelCell.swift 0% <ø> (ø) ⬆️
...hat/Views/Cells/Hints/UserHintAvatarViewCell.swift 0% <ø> (ø) ⬆️
.../Controllers/Chat/MessagesListViewController.swift 0% <ø> (ø) ⬆️
...at/MessagesViewControllerMessageCellProtocol.swift 0% <ø> (ø) ⬆️
...Chat/Views/Cells/Hints/TextHintEmojiViewCell.swift 0% <ø> (ø) ⬆️
Rocket.Chat/Theme/ThemeableViews.swift 51.94% <ø> (ø) ⬆️
Rocket.Chat/Views/Cells/Chat/ChatMessageCell.swift 0% <ø> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92cb228...a7bd599. Read the comment docs.

@rafaelks rafaelks merged commit 5d638ed into develop Jan 28, 2019
Cycle 13: 01/05 ~ 02/05 automation moved this from In progress to Done Jan 28, 2019
@rafaelks rafaelks deleted the chore/code_adjustments branch January 28, 2019 11:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants