This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[CHORE] Update RocketChatViewController & DifferenceKit #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 5, 2019
| @@ -517,7 +554,8 @@ internal func differentiate<E: Differentiable, I>( | |||
| let deleteOffset = sourceTraces[sourceIndex].deleteOffset | |||
| moved.append((source: mapIndex(sourceIndex - deleteOffset), target: mapIndex(targetIndex))) | |||
| } | |||
| } else { | |||
| } | |||
There was a problem hiding this comment.
Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration. (statement_position)
| } else { | ||
| updatedElements?(targetElement) | ||
| undeletedElements?(targetElement) | ||
| } |
There was a problem hiding this comment.
Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration. (statement_position)
Codecov Report
@@ Coverage Diff @@
## develop #2535 +/- ##
========================================
Coverage 26.45% 26.45%
========================================
Files 456 456
Lines 16867 16867
========================================
Hits 4463 4463
Misses 12404 12404Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Merges this PR into the app: RocketChat/RocketChatViewController#52