Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[BUG] New DMs after searching user are not getting created via API #2546

Merged
merged 2 commits into from Feb 12, 2019

Conversation

rafaelks
Copy link
Contributor

@RocketChat/ios

Closes #2437
Closes #2544

@rafaelks rafaelks added this to the 3.3.1 milestone Feb 12, 2019
@rafaelks rafaelks added this to In Progress in Cycle 14: 02/05 ~ 03/05 via automation Feb 12, 2019
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #2546 into develop will increase coverage by 0.05%.
The diff coverage is 35.29%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2546      +/-   ##
===========================================
+ Coverage    26.44%   26.49%   +0.05%     
===========================================
  Files          456      456              
  Lines        16878    16903      +25     
===========================================
+ Hits          4463     4479      +16     
- Misses       12415    12424       +9
Impacted Files Coverage Δ
...ubscriptionsList/SubscriptionsViewController.swift 2.47% <ø> (ø) ⬆️
...t.Chat/Models/Subscription/SubscriptionUtils.swift 33.75% <0%> (-0.43%) ⬇️
Rocket.Chat/Models/Subscription/Subscription.swift 47.61% <0%> (-2.39%) ⬇️
...Chat/Controllers/Chat/MessagesViewController.swift 34.25% <50%> (+3.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03c4eda...61ce211. Read the comment docs.

@rafaelks rafaelks merged commit 176750f into develop Feb 12, 2019
Cycle 14: 02/05 ~ 03/05 automation moved this from In Progress to Done Feb 12, 2019
@rafaelks rafaelks deleted the bug/new_dms_are_not_being_created.2437 branch February 12, 2019 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant