This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[FIX] Clear listeners for dynamic value in notifications #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m again Reloading cells caused multiple listeners to be registered which had a huge impact on performance and might cause other issues
Codecov Report
@@ Coverage Diff @@
## develop #2602 +/- ##
===========================================
- Coverage 25.99% 25.99% -0.01%
===========================================
Files 463 463
Lines 17203 17205 +2
===========================================
Hits 4472 4472
- Misses 12731 12733 +2
Continue to review full report at Codecov.
|
|
Great finding, thanks @artrmz! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear listeners for dynamic value in notifications before setting them again
Reloading cells caused multiple listeners to be registered which had a huge impact on performance and might cause other issues
@RocketChat/ios