Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX] Navigation bar disappears after subscription search #2640

Merged
merged 2 commits into from Apr 5, 2019

Conversation

rudrankriyam
Copy link
Contributor

@rudrankriyam rudrankriyam commented Apr 4, 2019

@RocketChat/ios

Closes #2631

Tiny fix, but solved the navigation bar disappearing.

NavigationBarAfter

But, while solving it, I found another bug.

The "Type a message" Composer View is missing.
Edit - It is a keyboard dismissal bug. Working on it.

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #2640 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2640   +/-   ##
========================================
  Coverage    26.17%   26.17%           
========================================
  Files          463      463           
  Lines        17224    17224           
========================================
  Hits          4509     4509           
  Misses       12715    12715
Impacted Files Coverage Δ
...ubscriptionsList/SubscriptionsViewController.swift 2.43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3949c4c...4fd00c5. Read the comment docs.

@SV8
Copy link

SV8 commented Apr 4, 2019

Great!

Now looks like not only navigation bar but also message composer disappeared.

@rudrankriyam
Copy link
Contributor Author

rudrankriyam commented Apr 4, 2019

@SV8 The navigation bar bug is solved with this PR. Message composer is due to a keyboard dismissal bug (in my opinion). Working on it 💯

@rafaelks rafaelks added this to the 3.5.0 milestone Apr 4, 2019
@SV8
Copy link

SV8 commented Apr 4, 2019

@snuff4 Got it. Thanks.

@rafaelks
Copy link
Contributor

rafaelks commented Apr 5, 2019

👍

@rafaelks rafaelks merged commit 5196a80 into RocketChat:develop Apr 5, 2019
@rudrankriyam rudrankriyam deleted the navigation_bar branch April 10, 2019 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[BUG] Navigation bar disappears after subscription search
3 participants