fix: cleaning the room filter between navigation on the admin section #20280
AllanPazRibeiroci.yml
on: pull_request
⚙️ Variables Setup
6s
Matrix: 🔎 Code Check / code-check
Matrix: 🚢 Build Docker Images for Testing
Matrix: 🔨 Test API (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test API (CE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (CE) / test
Waiting for pending jobs
Matrix: 🚢 Build Docker Images for Production
Matrix: 🚀 Publish Docker Image (main)
Matrix: 🚀 Publish Docker Image (services)
🚀 Notify external services
0s
trigger-dependent-workflows
0s
Annotations
9 errors and 20 warnings
|
🔎 Code Check / Code Lint
@rocket.chat/meteor#lint: command (/home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor) /tmp/xfs-b4f7859f/yarn run lint exited (1)
|
|
🔎 Code Check / Code Lint:
apps/meteor/tests/unit/client/views/admin/rooms/RoomsTable.spec.tsx#L11
There should be at least one empty line between import groups
|
|
🔎 Code Check / Code Lint:
apps/meteor/tests/unit/client/views/admin/rooms/RoomsTable.spec.tsx#L12
`@rocket.chat/mock-providers` import should occur before import of `@rocket.chat/ui-contexts`
|
|
|
|
🔎 Code Check / Code Lint:
apps/meteor/tests/unit/client/views/admin/rooms/RoomsTable.spec.tsx#L58
A function with a name starting with an uppercase letter should only be used as a constructor
|
|
🔎 Code Check / Code Lint:
apps/meteor/tests/unit/client/views/admin/rooms/RoomsTable.spec.tsx#L90
A function with a name starting with an uppercase letter should only be used as a constructor
|
|
🔎 Code Check / Code Lint:
apps/meteor/tests/unit/client/views/admin/rooms/RoomsTable.spec.tsx#L120
A function with a name starting with an uppercase letter should only be used as a constructor
|
|
🔎 Code Check / Code Lint:
apps/meteor/tests/unit/client/views/admin/rooms/RoomsTable.spec.tsx#L136
A function with a name starting with an uppercase letter should only be used as a constructor
|
|
🔎 Code Check / Code Lint
Process completed with exit code 1.
|
|
⚙️ Variables Setup
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Bhacaz/checkout-files@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
🚀 Notify external services - draft
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Bhacaz/checkout-files@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
📦 Build Packages
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/setup-node@v3.7.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
🔨 Test Unit / Unit Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/setup-node@v3.7.0, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
🔎 Code Check / TypeScript
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/setup-node@v3.7.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
📦 Meteor Build - coverage
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/setup-node@v3.7.0, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
🔎 Code Check / Code Lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/setup-node@v3.7.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/e2e/client/rocketchat.e2e.ts#L443
Prefer using an optional chain expression instead, as it's more concise and easier to read
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/lib/server/lib/debug.js#L83
Consider using the native Array.prototype.forEach() or Object.entries().forEach()
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/lib/server/oauth/oauth.js#L42
Consider using the native Array.prototype.includes()
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/lib/server/startup/rateLimiter.js#L65
Consider using the native Array.prototype.forEach() or Object.entries().forEach()
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/markdown/lib/hljs.js#L10
Async arrow function has a complexity of 173. Maximum allowed is 31
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts#L81
Static async method 'insertOrUpdateSAMLUser' has a complexity of 32. Maximum allowed is 31
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/reactions/client/init.ts#L32
Forbidden non-null assertion
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/threads/client/messageAction/replyInThread.ts#L24
Forbidden non-null assertion
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/utils/lib/restrictions.ts#L9
Consider using the native Array.prototype.map()
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/utils/lib/restrictions.ts#L20
Consider using the native Array.prototype.map()
|
|
🚢 Build Docker Images for Testing (official)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/login-action@v2, actions/download-artifact@v3, actions/cache@v3, actions/setup-node@v3.7.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
🚢 Build Docker Images for Testing (alpine)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/login-action@v2, actions/download-artifact@v3, actions/cache@v3, actions/setup-node@v3.7.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "build".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
build
|
306 MB |
|