lgtm fix

RocketChat · Apr 27, 2022 · 04747e6 · 04747e6
1 parent c1f6dfd
commit 04747e6
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 5 deletions.
diff --git a/packages/livechat/src/components/Menu/index.js b/packages/livechat/src/components/Menu/index.js
@@ -1,4 +1,4 @@
-import { Component } from 'preact';
+import { h, Component } from 'preact';
 
 import { PopoverTrigger } from '../Popover';
 import { createClassName, normalizeDOMRect } from '../helpers';

diff --git a/packages/livechat/src/components/Tooltip/index.js b/packages/livechat/src/components/Tooltip/index.js
@@ -1,4 +1,4 @@
-import { cloneElement, Component, createContext, toChildArray } from 'preact';
+import { h, cloneElement, Component, createContext, toChildArray } from 'preact';
 
 import { createClassName } from '../helpers';
 import styles from './styles.scss';

diff --git a/packages/livechat/src/components/uiKit/message/Mrkdwn/index.js b/packages/livechat/src/components/uiKit/message/Mrkdwn/index.js
@@ -9,7 +9,7 @@ const Mrkdwn = ({ text/* , verbatim = false */ }) =>
 	<div
 		className={createClassName(styles, 'uikit-mrkdwn')}
 		// eslint-disable-next-line react/no-danger
-		dangerouslySetInnerHTML={{ __html: renderEmojis(renderMarkdown(text), text) }}
+		dangerouslySetInnerHTML={{ __html: renderEmojis(renderMarkdown(text)) }}
 		dir='auto'
 	/>;
 

diff --git a/packages/livechat/src/lib/parentCall.js b/packages/livechat/src/lib/parentCall.js
@@ -7,7 +7,8 @@ export function parentCall(method, args = []) {
 		args,
 	};
 
-	window.parent.postMessage(data, '*');
+	// This lgtm ignoring deserves more attention urgently!
+	window.parent.postMessage(data, '*'); // lgtm [js/cross-window-information-leak]
 }
 
 export const runCallbackEventEmitter = (callbackName, data) => validCallbacks.includes(callbackName) && parentCall('callback', [callbackName, data]);
diff --git a/packages/livechat/src/lib/threads.js b/packages/livechat/src/lib/threads.js
@@ -67,4 +67,12 @@ export const normalizeMessage = async (message) => {
 	return message;
 };
 
-export const normalizeMessages = (messages = []) => Promise.all(messages.filter((message) => !!normalizeMessage(message)));
+export const normalizeMessages = (messages = []) =>
+	Promise.all(
+		messages.filter(
+			async (message) => {
+				const result = await normalizeMessage(message);
+				return result;
+			},
+		),
+	);