fix: User status when setting "Use REST instead of websocket for Mete…

…or calls" is disabled (#32500)

.changeset/serious-bottles-tie.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fix user not being set as online when setting "Use REST instead of websocket for Meteor calls" is disabled

apps/meteor/client/sidebar/header/UserMenu.tsx

@@ -28,6 +28,7 @@ const UserMenu = ({ user }: { user: IUser }) => {
 					selectionMode='multiple'
 					sections={sections}
 					title={t('User_menu')}
+					aria-label={t('User_menu')}
 					onAction={handleAction}
 					isOpen={isOpen}
 					onOpenChange={setIsOpen}
@@ -41,6 +42,7 @@ const UserMenu = ({ user }: { user: IUser }) => {
 					selectionMode='multiple'
 					sections={sections}
 					title={t('User_menu')}
+					aria-label={t('User_menu')}
 					onAction={handleAction}
 					isOpen={isOpen}
 					onOpenChange={setIsOpen}

apps/meteor/ee/server/startup/presence.ts

@@ -30,7 +30,7 @@ Meteor.startup(() => {
 	});
 
 	Accounts.onLogin((login: any): void => {
-		if (login.type !== 'resume' || !login.connection.id) {
+		if (!login.connection.id) {
 			return;
 		}
 

apps/meteor/tests/e2e/presence.spec.ts

@@ -0,0 +1,48 @@
+import { DEFAULT_USER_CREDENTIALS, IS_EE } from './config/constants';
+import { Registration } from './page-objects';
+import { setSettingValueById } from './utils/setSettingValueById';
+import { test, expect } from './utils/test';
+
+test.describe.serial('Presence', () => {
+	let poRegistration: Registration;
+
+	test.beforeEach(async ({ page }) => {
+		poRegistration = new Registration(page);
+
+		await page.goto('/home');
+	});
+
+	test.beforeAll(async ({ api }) => {
+		await expect((await setSettingValueById(api, 'API_Use_REST_For_DDP_Calls', true)).status()).toBe(200);
+	});
+
+	test.afterAll(async ({ api }) => {
+		await expect((await setSettingValueById(api, 'API_Use_REST_For_DDP_Calls', true)).status()).toBe(200);
+	});
+
+	test.describe('Login using default settings', () => {
+		test('expect user to be online after log in', async ({ page }) => {
+			await poRegistration.username.type('user1');
+			await poRegistration.inputPassword.type(DEFAULT_USER_CREDENTIALS.password);
+			await poRegistration.btnLogin.click();
+
+			await expect(page.getByRole('button', { name: 'User menu' }).locator('.rcx-status-bullet--online')).toBeVisible();
+		});
+	});
+
+	test.describe('Login using with "Methods by REST" disabled', () => {
+		test.skip(IS_EE, `Micro services don't support turning this setting off`);
+
+		test.beforeAll(async ({ api }) => {
+			await expect((await setSettingValueById(api, 'API_Use_REST_For_DDP_Calls', false)).status()).toBe(200);
+		});
+
+		test('expect user to be online after log in', async ({ page }) => {
+			await poRegistration.username.type('user1');
+			await poRegistration.inputPassword.type(DEFAULT_USER_CREDENTIALS.password);
+			await poRegistration.btnLogin.click();
+
+			await expect(page.getByRole('button', { name: 'User menu' }).locator('.rcx-status-bullet--online')).toBeVisible();
+		});
+	});
+});