Added custom sound error

RocketChat · Feb 17, 2022 · 25c1715 · 25c1715
1 parent 3a47726
commit 25c1715
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/client/views/admin/customSounds/AddCustomSound.js b/client/views/admin/customSounds/AddCustomSound.js
@@ -57,7 +57,7 @@ function AddCustomSound({ goToNew, close, onChange, ...props }) {
 				return soundId;
 			}
 			validation.forEach((error) => {
-				throw new Error({
+				dispatchToastMessage({
 					type: 'error',
 					message: t('error-the-field-is-required', { field: t(error) }),
 				});

diff --git a/client/views/admin/customSounds/lib.js b/client/views/admin/customSounds/lib.js
@@ -22,14 +22,13 @@ export function validate(soundData, soundFile) {
 }
 
 export function createSoundData(soundFile, name = '', previousData) {
-	const soundData = {
-		extension: soundFile.name.split('.').pop(),
-	};
+	const soundData = {};
 
 	if (previousData) {
 		soundData._id = previousData._id;
 		soundData.previousName = previousData.previousName;
 		soundData.previousSound = previousData.previousSound;
+		soundData.extension = soundFile.name.split('.').pop();
 		soundData.previousExtension = previousData.previousSound.extension;
 		soundData.name = name;
 		soundData.newFile = false;