Regression: Support generating pdfs from queue (#28162)

RocketChat · Feb 28, 2023 · 3418e20 · 3418e20
1 parent a05fb3c
commit 3418e20
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 13 deletions.
diff --git a/apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json b/apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json
@@ -3544,6 +3544,7 @@
   "Not_authorized": "Not authorized",
   "Normal": "Normal",
   "Not_Available": "Not Available",
+  "Not_assigned": "Not assigned",
   "Not_enough_data": "Not enough data",
   "Not_following": "Not following",
   "Not_Following": "Not Following",

diff --git a/apps/meteor/tests/end-to-end/api/livechat/00-rooms.ts b/apps/meteor/tests/end-to-end/api/livechat/00-rooms.ts
@@ -1652,14 +1652,14 @@ describe('LIVECHAT - rooms', function () {
 				.set(credentials)
 				.expect(400);
 		});
-		it('should fail if no one is serving the room', async () => {
+		it('should return OK if no one is serving the room (queued)', async () => {
 			const visitor = await createVisitor();
 			const { _id } = await createLivechatRoom(visitor.token);
 			await closeRoom(_id);
 			await request
 				.post(api(`omnichannel/${_id}/request-transcript`))
 				.set(credentials)
-				.expect(400);
+				.expect(200);
 		});
 		let roomId: string;
 		it('should request a pdf transcript when all conditions are met', async () => {

diff --git a/ee/packages/omnichannel-services/src/OmnichannelTranscript.ts b/ee/packages/omnichannel-services/src/OmnichannelTranscript.ts
@@ -118,7 +118,7 @@ export class OmnichannelTranscript extends ServiceClass implements IOmnichannelT
 			throw new Error('room-still-open');
 		}
 
-		if (!room.servedBy || !room.v) {
+		if (!room.v) {
 			throw new Error('improper-room-state');
 		}
 
@@ -208,15 +208,7 @@ export class OmnichannelTranscript extends ServiceClass implements IOmnichannelT
 	}
 
 	private async getTranslations(): Promise<Array<{ key: string; value: string }>> {
-		const keys: string[] = [
-			'Agent',
-			'Date',
-			'Customer',
-			'Omnichannel_Agent',
-			'Time',
-			'Chat_transcript',
-			'This_attachment_is_not_supported',
-		];
+		const keys: string[] = ['Agent', 'Date', 'Customer', 'Not_assigned', 'Time', 'Chat_transcript', 'This_attachment_is_not_supported'];
 
 		return Promise.all(
 			keys.map(async (key) => {

diff --git a/ee/packages/pdf-worker/src/templates/ChatTranscript/index.tsx b/ee/packages/pdf-worker/src/templates/ChatTranscript/index.tsx
@@ -43,7 +43,7 @@ const styles = StyleSheet.create({
 });
 
 export const ChatTranscriptPDF = ({ header, messages, t }: ChatTranscriptData) => {
-	const agentValue = header.agent?.name || header.agent?.username || t('Omnichannel_Agent');
+	const agentValue = header.agent?.name || header.agent?.username || t('Not_assigned');
 	const customerValue = header.visitor?.name || header.visitor?.username;
 	const dateValue = header.date;
 	const timeValue = header.time;