[FIX] Wordpress OAuth not providing enough info to log in (#11152)

RocketChat · Jun 15, 2018 · 3e6f24f · 3e6f24f
1 parent 85b662b
commit 3e6f24f
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 8 deletions.
diff --git a/packages/rocketchat-api/server/v1/settings.js b/packages/rocketchat-api/server/v1/settings.js
@@ -35,7 +35,7 @@ RocketChat.API.v1.addRoute('settings.oauth', { authRequired: false }, {
 			const oAuthServicesEnabled = ServiceConfiguration.configurations.find({}, { fields: { secret: 0 } }).fetch();
 
 			return oAuthServicesEnabled.map((service) => {
-				if (service.custom || ['saml', 'cas'].includes(service.service)) {
+				if (service.custom || ['saml', 'cas', 'wordpress'].includes(service.service)) {
 					return { ...service };
 				}
 

diff --git a/packages/rocketchat-wordpress/common.js b/packages/rocketchat-wordpress/common.js
@@ -13,7 +13,7 @@ const config = {
 
 const WordPress = new CustomOAuth('wordpress', config);
 
-const fillSettings = _.debounce(() => {
+const fillSettings = _.debounce(Meteor.bindEnvironment(() => {
 	config.serverURL = RocketChat.settings.get('API_Wordpress_URL');
 
 	delete config.identityPath;
@@ -46,18 +46,34 @@ const fillSettings = _.debounce(() => {
 			}
 			break;
 		case 'wordpress-com':
-			config.identityPath = '/rest/v1/me';
+			config.identityPath = 'https://public-api.wordpress.com/rest/v1/me';
 			config.identityTokenSentVia = 'header';
-			config.authorizePath = '/oauth2/authorize';
-			config.tokenPath = '/oauth2/token';
+			config.authorizePath = 'https://public-api.wordpress.com/oauth2/authorize';
+			config.tokenPath = 'https://public-api.wordpress.com/oauth2/token';
 			config.scope = 'auth';
 			break;
 		default:
 			config.identityPath = '/oauth/me';
 			break;
 	}
-	return WordPress.configure(config);
-}, 1000);
+
+	const result = WordPress.configure(config);
+
+	const enabled = RocketChat.settings.get('Accounts_OAuth_Wordpress');
+	if (enabled) {
+		ServiceConfiguration.configurations.upsert({
+			service: 'wordpress'
+		}, {
+			$set: config
+		});
+	} else {
+		ServiceConfiguration.configurations.remove({
+			service: 'wordpress'
+		});
+	}
+
+	return result;
+}), 1000);
 
 if (Meteor.isServer) {
 	Meteor.startup(function() {

diff --git a/packages/rocketchat-wordpress/startup.js b/packages/rocketchat-wordpress/startup.js
@@ -39,7 +39,8 @@ RocketChat.settings.addGroup('OAuth', function() {
 					key: 'custom',
 					i18nLabel: 'Accounts_OAuth_Wordpress_server_type_custom'
 				}
-			]
+			],
+			i18nLabel: 'Server_Type'
 		});
 
 		const customOAuthQuery = [{