Skip to content

Commit

Permalink
[FIX] Update import from csv-parse (#25872)
Browse files Browse the repository at this point in the history
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
<!-- CHANGELOG -->
<!--
  Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
  If it fixes a bug or resolves a feature request, be sure to link to that issue below.
  This description will appear in the release notes if we accept the contribution.
-->

This PR updates the importing of `csv-parse` because the used method wasn't working anymore, we were receiving the following error:

`error: "this.csvParser is not a function"`

<!-- END CHANGELOG -->

## Issue(s)
<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->

## Steps to test or reproduce
<!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->

## Further comments
<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
  • Loading branch information
LucianoPierdona committed Jun 16, 2022
1 parent 750f0ef commit 419f07a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion apps/meteor/app/importer-csv/server/importer.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ export class CsvImporter extends Base {
constructor(info, importRecord) {
super(info, importRecord);

this.csvParser = require('csv-parse/lib/sync');
const { parse } = require('csv-parse/lib/sync');

this.csvParser = parse;
}

prepareUsingLocalFile(fullFilePath) {
Expand Down
4 changes: 3 additions & 1 deletion apps/meteor/app/importer-slack-users/server/importer.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ export class SlackUsersImporter extends Base {
constructor(info, importRecord) {
super(info, importRecord);

this.csvParser = require('csv-parse/lib/sync');
const { parse } = require('csv-parse/lib/sync');

this.csvParser = parse;
this.userMap = new Map();
this.admins = []; // Array of ids of the users which are admins
}
Expand Down

0 comments on commit 419f07a

Please sign in to comment.