fix: remove code that was setting mail_url to 'undefined' (#30055)

RocketChat · Aug 11, 2023 · 6eea189 · 6eea189
1 parent 87570d0
commit 6eea189
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/pink-zoos-join.md b/.changeset/pink-zoos-join.md
@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": patch
+---
+
+Fix the code that was setting email URL to an invalid value when SMTP was not set
diff --git a/apps/meteor/app/lib/server/startup/settingsOnLoadSMTP.ts b/apps/meteor/app/lib/server/startup/settingsOnLoadSMTP.ts
@@ -5,7 +5,7 @@ settings.watchMultiple(['SMTP_Host', 'SMTP_Port', 'SMTP_Username', 'SMTP_Passwor
 	SystemLogger.info('Updating process.env.MAIL_URL');
 
 	if (!settings.get('SMTP_Host')) {
-		process.env.MAIL_URL = undefined;
+		delete process.env.MAIL_URL;
 		return;
 	}