[FIX] NPS never finishing sending results (#25067)

RocketChat · Apr 7, 2022 · b50b84c · b50b84c
1 parent 1ec8eef
commit b50b84c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/server/services/nps/sendNpsResults.ts b/server/services/nps/sendNpsResults.ts
@@ -8,7 +8,7 @@ import { SystemLogger } from '../../lib/logger/system';
 
 type NPSResultPayload = {
 	total: number;
-	votes: INpsVote[];
+	votes: Pick<INpsVote, 'identifier' | 'roles' | 'score' | 'comment'>[];
 };
 
 export const sendNpsResults = Meteor.bindEnvironment(function sendNpsResults(npsId: string, data: NPSResultPayload) {

diff --git a/server/services/nps/service.ts b/server/services/nps/service.ts
@@ -109,7 +109,6 @@ export class NPSService extends ServiceClassInternal implements INPSService {
 					},
 					{
 						projection: {
-							_id: 0,
 							identifier: 1,
 							roles: 1,
 							score: 1,
@@ -121,17 +120,24 @@ export class NPSService extends ServiceClassInternal implements INPSService {
 			}),
 		);
 
-		const votes = sending.filter(Boolean) as INpsVote[];
+		const votes = sending.filter(Boolean) as Pick<INpsVote, '_id' | 'identifier' | 'roles' | 'score' | 'comment'>[];
 		if (votes.length > 0) {
 			const voteIds = votes.map(({ _id }) => _id);
 
+			const votesWithoutIds = votes.map(({ identifier, roles, score, comment }) => ({
+				identifier,
+				roles,
+				score,
+				comment,
+			}));
+
 			const payload = {
 				total,
-				votes,
+				votes: votesWithoutIds,
 			};
 			sendNpsResults(nps._id, payload);
 
-			this.NpsVote.updateVotesToSent(voteIds);
+			await this.NpsVote.updateVotesToSent(voteIds);
 		}
 
 		const totalSent = await this.NpsVote.findByNpsIdAndStatus(nps._id, INpsVoteStatus.SENT).count();