Skip to content

Commit

Permalink
Fixed svg for older chrome browsers bug #11414
Browse files Browse the repository at this point in the history
  • Loading branch information
tpDBL committed Jul 10, 2018
1 parent bf38c7f commit ec92ef6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/rocketchat-ui-master/client/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import s from 'underscore.string';

RocketChat.settings.collection.find({_id:/theme-color-rc/i}, {fields:{ value: 1 }}).observe({changed: () => { DynamicCss.run(true); }});

this.isFirefox = navigator.userAgent.match(/Firefox\/(\d+)\.\d/);
this.isFirefox = navigator.userAgent.match(/(Firefox|Chrome)\/(\d+)\.\d/);

Template.body.onRendered(function() {
new Clipboard('.clipboard');
Expand Down
2 changes: 1 addition & 1 deletion packages/rocketchat-ui/client/components/icon.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
const firefoxBaseUrlFix = () => `${ window.location.origin }${ FlowRouter.current().path }`;

Template.icon.helpers({
baseUrl: isFirefox && isFirefox[1] < 55 ? firefoxBaseUrlFix : undefined
baseUrl: isFirefox && isFirefox[2] < 55 ? firefoxBaseUrlFix : undefined

This comment has been minimized.

Copy link
@shahar3012

shahar3012 Jul 18, 2018

Contributor

55 is the Firefox version. right?
Did you check that it's working on Chrome 51?
For me it didn't work at previous versions of Rocket.Chat on Chrome 51.

This comment has been minimized.

Copy link
@tassoevan

tassoevan Jul 18, 2018

Contributor

I'll check that.

This comment has been minimized.

Copy link
@tassoevan

tassoevan Jul 18, 2018

Contributor
});

0 comments on commit ec92ef6

Please sign in to comment.