Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory channel listing has incorrect behaviour in high Y resolutions #10024

Closed
Jannibal opened this issue Mar 6, 2018 · 6 comments · Fixed by #10403
Closed

Directory channel listing has incorrect behaviour in high Y resolutions #10024

Jannibal opened this issue Mar 6, 2018 · 6 comments · Fixed by #10403
Assignees
Projects
Milestone

Comments

@Jannibal
Copy link

Jannibal commented Mar 6, 2018

Description:

Directory does not list all channels when placing Rocket.Chat on a monitor in portrait mode (resolution based).

Server Setup Information:

  • Version of Rocket.Chat Server: 0.62.1
  • Operating System: Ubuntu 16.04.3 LTS
  • Deployment Method(snap/docker/tar/etc): Snap
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • Node Version: v8.8.1
  • mongoDB Version: ?

Steps to Reproduce:

  1. Place Chrome tab in fullscreen on a monitor in portrait mode (with height more than ~1200 pixels)
  2. Click directory button

Expected behavior:

All the channels available should be listed

Actual behavior:

Few channels are listed, and cannot scroll further. Sorting by name "works" since the end of the channel list appears at the top, but scrolling is still not possible.

Additional information

Different resolutions changes the behaviour:
1920x1200 (landscape) Works
1200x1920 (portrait) Doesn't work

Resolutions tested on the same monitor with same orientation:
2560x1440 (landscape) Doesn't work
1920x1080 (landscape) Works

So it would seem that the resolution is the culprit in this case,.

@lunaticmonk
Copy link
Contributor

@Jannibal Can you provide screenshots or gif? It would be really be helpful to visualize things. Thanks.

@Jannibal
Copy link
Author

Jannibal commented Mar 6, 2018

You can see the same directory view on two different monitors below.
In the landscape one, it works as intended, with a scroll bar on the right side which allows the user to scroll down and see all the channels
landscape

In the portrait version (with the same resolution, but other orientation) the scroll bar is not present, and the channels look like they "end". There are more channels, but they are not rendered, and there's no scroll bar.

portrait

This problem is present on other monitors that have different resolutions, but in the same orientation. Eg. if I have a monitor with 2560x1440 resolution (still landscape), this problem persists.

Also checked this problem with the Rocket.Chat+ client for Windows, and it's there too. So Chrome Win+Linux and Rocket.Chat+ client for Windows has this problem.

Sorry for the heavily censored screen shots.

@theorenck
Copy link
Contributor

Thanks @Jannibal. @karlprieb can you confirm it as a duplicate?

@mddvul22
Copy link

mddvul22 commented Mar 16, 2018

This is happening for me on the Rocket Chat demo server, using either firefox or Chrome in landscape mode. The below screenshot is from Firefox 52 ESR. There is no scroll bar. It only shows 10 channels.

screenshot-1521224059

@Eiken
Copy link

Eiken commented Mar 28, 2018

Same here. It seems to be related to running a monitor with such high resolution that the scrollbar is never initialized. If I zoom in to make the scrollbar appear it starts to work.

@theorenck theorenck added this to Desireable in 0.64.0 via automation Apr 9, 2018
@karlprieb karlprieb moved this from Desireable to Backlog in 0.64.0 Apr 9, 2018
@ggazzo ggazzo self-assigned this Apr 10, 2018
@ggazzo ggazzo moved this from Backlog to In progress in 0.64.0 Apr 10, 2018
@karlprieb karlprieb moved this from In progress to Review/QA in 0.64.0 Apr 11, 2018
@karlprieb karlprieb moved this from Review/QA to Ready to merge in 0.64.0 Apr 11, 2018
0.64.0 automation moved this from Ready to merge to Done Apr 19, 2018
@Gummikavalier
Copy link

Gummikavalier commented May 19, 2018

We were still experiencing this in 0.64.2 with Firefox.

Custom CSS workaround:

section.rc-directory {
	height: 99% ;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.64.0
  
Done
Development

Successfully merging a pull request may close this issue.

8 participants