[FIX] Directory sort and column sizes were wrong #10403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
changed the title
karlprieb
suggested changes
Apr 11, 2018
| flex-grow: 1; | ||
|
|
||
| white-space: nowrap; | ||
| overflow: hidden; |
fix indentation
karlprieb
previously approved these changes
Apr 17, 2018
graywolf336
suggested changes
Apr 18, 2018
| <thead class="rc-table-head"> | ||
| <tr class="rc-table-tr"> | ||
| <td class="rc-table-td js-sort" data-sort="name">Name {{> icon icon=(sortIcon 'name')}}</td> | ||
| <td class="rc-table-td js-sort" data-sort="usernames">Users {{> icon icon=(sortIcon 'usernames') }}</td> | ||
| <td class="rc-table-td js-sort" data-sort="createdAt">Created At {{> icon icon=(sortIcon 'createdAt') }}</td> | ||
| <td class="rc-table-td rc-table-td--users">Users</td> |
There was a problem hiding this comment.
The Users is not i18n'd.
| @@ -19,12 +19,12 @@ | |||
| {{/header}} | |||
| <div class="rc-directory-content"> | |||
| {{#if $eq searchType 'channels'}} | |||
| <table class="rc-table"> | |||
| <table class="rc-table rc-table--fixed"> | |||
| <thead class="rc-table-head"> | |||
| <tr class="rc-table-tr"> | |||
| <td class="rc-table-td js-sort" data-sort="name">Name {{> icon icon=(sortIcon 'name')}}</td> | |||
There was a problem hiding this comment.
The Name is not i18n'd.
| <td class="rc-table-td js-sort" data-sort="usernames">Users {{> icon icon=(sortIcon 'usernames') }}</td> | ||
| <td class="rc-table-td js-sort" data-sort="createdAt">Created At {{> icon icon=(sortIcon 'createdAt') }}</td> | ||
| <td class="rc-table-td rc-table-td--users">Users</td> | ||
| <td class="rc-table-td js-sort rc-table-td--createdAt" data-sort="createdAt">Created At {{> icon icon=(sortIcon 'createdAt') }}</td> |
There was a problem hiding this comment.
The Created At is not i18n'd.
|
@graywolf336 done :) Thank you for your review 👍 |
graywolf336
approved these changes
Apr 18, 2018
rodrigok
changed the title
MarcosSpessatto
added a commit
that referenced
this pull request
Apr 19, 2018
…-api-chat-postmessage-validations * commit 'a9fb4da5c847a456990a5d60369f0f52ff4a8bd8': (137 commits) Remove "secret" from REST endpoint /settings.oauth response [FIX] Directory sort and column sizes were wrong (#10403) [FIX] Add oauth services missing fields, and indicate whether the oauth service is customized (#10299) Show error message when email verification fails (#10446) Correct the column positions in the directory search for users (#10454) Fixed custom fields misalignment in registration form (#10463) [FIX] Unique identifier file not really being unique (#10341) [OTHER] More Listeners for Apps & Utilize Promises inside Apps (#10335) [FIX] Empty panel after changing a user's username (#10404) [FIX] Russian translation of "False" (#10418) [FIX] Links being embedded inside of blockquotes (#10496) [FIX] The 'channel.messages' REST API Endpoint error (#10485) [OTHER] Develop sync (#10487) [FIX] Button on user info contextual bar scrolling with the content (#10358) [FIX] "Idle Time Limit" using milliseconds instead of seconds (#9824) [NEW] Body of the payload on an incoming webhook is included on the request object (#10259) [FIX] Missing i18n translation key for "Unread" (#10387) [FIX] Owner unable to delete channel or group from APIs (#9729) [NEW] REST endpoint to recover forgotten password (#10371) Add REST endpoint chat.reportMessage, to report a message (#10354) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can`t sort by array length, (actually we can but its very expensive)
closes #9817
closes #10024
before:
after: