[BUG] /api/v1/users.updateOwnBasicInfo not working properly

[filipealva]

When trying to set a username for a new user on a server with customFields enabled the API is returning the following response:

[REST][RESULT][https://rafaelks.rocket.chat/api/v1/users.updateOwnBasicInfo]: {
  "error" : "Cannot read property 'role' of undefined",
  "success" : false
}.

The problem is: It says that the request has failed (success: false) but it's a false positive because the username is actually set, so the request has updated the user info and so it was successful.

[sampaiodiego]

what are the customFields configured?

[filipealva]

@sampaiodiego

• Role (teacher, student)
• Twitter

I think that these are the default ones suggested on the docs.

I'm using https://rafaelks.rocket.chat/ for testing, if you want to take a look.

[rafaelks]

This is what happens, when trying to signup in any client with custom fields and setting a username (there's no way to signup with one API, we need to use two):

[sampaiodiego]

@filipealva can you please post the JSON used to configure the custom fields?

also can you send the exactly request payloads and responses? thx

[rafaelks]

@sampaiodiego

{
    "role": {
        "type": "select",
        "defaultValue": "student",
        "options": ["teacher", "student"],
        "required": true,
        "modifyRecordField": {
            "array": true,
            "field": "roles"
        }
    },
    "twitter": {
        "type": "text",
        "required": true,
        "minLength": 2,
        "maxLength": 10
    }
}

[filipealva]

@sampaiodiego

1. First we grab the user info from the fields and send a signup request to the RealTime API with the following payload:

{
  "method" : "registerUser",
  "id" : "jMJm7kaA60IROhyXNcK24B2QRT3hjfszOXZfxNuA5xxn7kVuqe",
  "params" : [
    {
      "name" : "test0111",
      "email" : "test0111@test.com",
      "pass" : "123456",
      "role" : "student",
      "twitter" : "filipealva"
    }
  ],
  "msg" : "method"
}

2. It succeeds with no error.

3. We authenticate the user we've just created:

[REST][REQUEST]: https://rafaelks.rocket.chat/api/v1/login: {
  "user" : {
    "email" : "test0111@test.com"
  },
  "password" : {
    "algorithm" : "sha-256",
    "digest" : "8d969eef6ecad3c29a3a629280e686cf0c3f5d5a86aff3ca12020c923adc6c92"
  }
}

4. It succeeds with no error.

[REST][RESULT][https://rafaelks.rocket.chat/api/v1/login]: {
  "status" : "success",
  "data" : {
    "authToken" : "VwPdFJd6A_ecU8u67O7FVJGA-9rjy76_otmljVFnsyt",
    "userId" : "G5A9eDDQYFMQhtqsb",
    "me" : {
      "status" : "offline",
      "name" : "test0111",
      "_id" : "G5A9eDDQYFMQhtqsb",
      "settings" : {
        "preferences" : {
          "newRoomNotification" : "door",
          "mergeChannels" : false,
          "collapseMediaByDefault" : false,
          "saveMobileBandwidth" : true,
          "roomCounterSidebar" : false,
          "sidebarViewMode" : "medium",
          "sidebarShowUnread" : false,
          "hideUsernames" : false,
          "enableAutoAway" : false,
          "desktopNotificationDuration" : 0,
          "idleTimeoutLimit" : 300,
          "notificationsSoundVolume" : 100,
          "newMessageNotification" : "chime",
          "hideAvatars" : false,
          "desktopNotifications" : "mentions",
          "mobileNotifications" : "mentions",
          "useEmojis" : true,
          "hideFlexTab" : false,
          "unreadAlert" : true,
          "sidebarHideAvatar" : false,
          "sidebarShowFavorites" : true,
          "convertAsciiEmoji" : true,
          "messageViewMode" : 0,
          "autoImageLoad" : true,
          "emailNotificationMode" : "mentions",
          "audioNotifications" : "mentions",
          "roomsListExhibitionMode" : "category",
          "muteFocusedConversations" : true,
          "hideRoles" : false,
          "viewMode" : 0,
          "sendOnEnter" : "normal"
        }
      },
      "roles" : [
        "user",
        "student"
      ],
      "active" : true,
      "emails" : [
        {
          "verified" : false,
          "address" : "test0111@test.com"
        }
      ]
    }
  }

5. Then we set the username of our new user:

[REST][REQUEST]: https://rafaelks.rocket.chat/api/v1/users.updateOwnBasicInfo: {
  "data" : {
    "username" : "test0111"
  }
}

6. It returns this error:

[REST][RESULT][https://rafaelks.rocket.chat/api/v1/users.updateOwnBasicInfo]: {
  "error" : "Cannot read property 'role' of undefined",
  "success" : false
}

We have to chain these requests because our API doesn't support signing up the username on our first request, so we must signup the user, then authenticate him, then set its username. The process is messed up by definition but it usually works fine, the problem is happening only when setting a username when the server has custom fields enabled.

[rodrigok]

Closed by #11204