Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Wizard ignores an invalid username in "Admin Info" step #11198

Closed
tassoevan opened this issue Jun 20, 2018 · 0 comments · Fixed by #11254
Closed

Setup Wizard ignores an invalid username in "Admin Info" step #11198

tassoevan opened this issue Jun 20, 2018 · 0 comments · Fixed by #11254
Assignees
Milestone

Comments

@tassoevan
Copy link
Contributor

Description:

Usernames which don't follow the default UTF8_Names_Validation regular expression ([0-9a-zA-Z-_.]+) in "Admin Info" step of Setup Wizard are ignored until the wizard finishes, where a "Register Username" modal appears.

Steps to reproduce:

  1. In a fresh install, open the Setup Wizard;
  2. Input a username that doesn't match the UTF8_Names_Validation settings (suggested: #####);
  3. Fill out the "Admin Info" form with the additional requested info;
  4. Click "Continue".

Expected behavior:

An error message is shown below the Username input and the Setup Wizard remains in the "Admin Info" step.

Actual behavior:

A error notification username-invalid is shown in the upper right corner of the browser viewport and the Setup Wizard advances to the next step.

Server Setup Information:

  • Version of Rocket.Chat Server: 0.66.0-develop
  • Operating System: Linux
  • Deployment Method: all
  • Number of Running Instances: 1
  • DB Replicaset Oplog: enabled
  • NodeJS Version: 8.11.1 - x64
  • MongoDB Version: 3.4
@tassoevan tassoevan self-assigned this Jun 20, 2018
@ggazzo ggazzo added this to the 0.67.0 milestone Jun 26, 2018
@tassoevan tassoevan modified the milestones: 0.67.0, 0.66.1 Jul 3, 2018
ggazzo pushed a commit that referenced this issue Jul 3, 2018
…ptout (#11254)

Closes #11198 

- [x] Show all steps on info box
- [x] Properly display errors in registration process of admin user
- [x] Break steps in subtemplates
- [x] Redesign "Register Server" step
      ![Register Server](https://user-images.githubusercontent.com/2263066/42013253-cd691bc2-7a72-11e8-8832-fe9ccd9e89b4.png)
- [x] Update end-to-end tests
rodrigok pushed a commit that referenced this issue Jul 4, 2018
…ptout (#11254)

Closes #11198 

- [x] Show all steps on info box
- [x] Properly display errors in registration process of admin user
- [x] Break steps in subtemplates
- [x] Redesign "Register Server" step
      ![Register Server](https://user-images.githubusercontent.com/2263066/42013253-cd691bc2-7a72-11e8-8832-fe9ccd9e89b4.png)
- [x] Update end-to-end tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants