Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

German translation of "You reacted with ..." incorrect #12720

Closed
localguru opened this issue Nov 25, 2018 · 2 comments · Fixed by #12761
Closed

German translation of "You reacted with ..." incorrect #12720

localguru opened this issue Nov 25, 2018 · 2 comments · Fixed by #12761
Labels
feat: i18n type: bug

Comments

@localguru
Copy link
Contributor

localguru commented Nov 25, 2018 •
edited
Loading

Description:

The German translation of a reaction ("You reacted with") is not correct. It must read: "Sie reagierten mit: ..." instead of "Sie reagierte mit: ...".

Steps to reproduce:

  1. Set your profile to German
  2. react on a message
  3. move the mouse over the reaction

Expected behavior:

It must read: "Sie reagierten mit: ..." .

Actual behavior:

Translation is "Sie reagierte mit: ..." .

typo

Server Setup Information:

  • Version of Rocket.Chat Server: 0.72.0-rc.1 (open.rocket.chat)
@localguru
Copy link
Contributor Author

And why use the formal term of address "Sie" instead of "Du". I would prefer the German "Du".

@zdumitru
Copy link
Contributor

https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/rocketchat-i18n/i18n/de-IN.i18n.json#L2092

@localguru localguru mentioned this issue Nov 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat: i18n type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

German translation typo fix for Reacted_with localguru/Rocket.Chat.LG
3 participants
@tassoevan @localguru @zdumitru