RESTAPI: missing add/remove leader

[Montel]

In last version we don"t have rest api for adding/removing leader role:

We have method for adding/removing Moderator/Owner role but not leader.

I think that we need code as:

RocketChat.API.v1.addRoute('channels.addLeader', { authRequired: true }, {
        post() {
                const findResult = findChannelByIdOrName({ params: this.requestParams() });

                const user = this.getUserFromParams();

                Meteor.runAsUser(this.userId, () => {
                        Meteor.call('addRoomLeader', findResult._id, user._id);
                });

                return RocketChat.API.v1.success();
        },
});

RocketChat.API.v1.addRoute('channels.removeLeader', { authRequired: true }, {
        post() {
                const findResult = findChannelByIdOrName({ params: this.requestParams() });

                const user = this.getUserFromParams();

                Meteor.runAsUser(this.userId, () => {
                        Meteor.call('removeRoomLeader', findResult._id, user._id);
                });

                return RocketChat.API.v1.success();
        },
});

Regards.

[ggazzo]

hey @Montel looking your snippet seems you are in the right path, why not open a pull request? feel free to open and we can help you to merge it :)

[Montel]

I can try to make a pull request tomorrow.
I need it for my rocketchat client (kde - ruqola)

I will do it tomorrow

[Montel]

Montel#1
I created this pull request I think :)
Not sure that all is ok

[MarcosSpessatto]

@Montel I think you opened the PR only in your fork, you should open the PR and choose as the target branch: RocketChat:develop and not the develop branch of your fork. 😅 Can you please fix it?

[Montel]

Ah !
Sorry I didn't use a lot github :) I will try to fix it soon :)

[MarcosSpessatto]

No problem :)

[Montel]

#13314

it seems that I need to add some reviewer but I don't know who (and how :) )

[MarcosSpessatto]

I'll do that. :)

[Montel]

oops sorry I wanted to update my patch and it closed it...
I recreated a new one:
#13315

I hope that it'"s ok.