Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Add missing remove add leader channel #13315

Merged
merged 6 commits into from
Feb 18, 2019
Merged

[NEW] Add missing remove add leader channel #13315

merged 6 commits into from
Feb 18, 2019

Conversation

Montel
Copy link
Contributor

@Montel Montel commented Feb 1, 2019 •
edited by MarcosSpessatto
Loading

Closes #13315

@Montel Montel mentioned this pull request Feb 1, 2019
Closed
@MarcosSpessatto
Copy link
Contributor

MarcosSpessatto commented Feb 1, 2019 •
edited
Loading

@Montel can you please add these endpoint to the groups. as well? It would be interesting to have these possibilities in groups too. What do you think?

@Montel
Copy link
Contributor Author

Montel commented Feb 1, 2019

it's already implemented :)

@Montel
Copy link
Contributor Author

Montel commented Feb 1, 2019

groups.addLeader and groups.removeLeader is already implemented.
It was just missed for channels.

@Montel Montel closed this Feb 1, 2019
@Montel Montel reopened this Feb 1, 2019
@MarcosSpessatto
Copy link
Contributor

Oh, you're right. I'll implement some tests for these endpoints, or you can take care of this?

@Montel
Copy link
Contributor Author

Montel commented Feb 1, 2019

Please do it :) You know better it as me :)
I will work on other missing RESTAPI that I found :)

Thanks

@Montel
Copy link
Contributor Author

Montel commented Feb 4, 2019

(Another request #13334 it's about typo in command name, I don't know how to add requester). Regards

@MarcosSpessatto MarcosSpessatto added this to the 0.75.0 milestone Feb 11, 2019
@MarcosSpessatto MarcosSpessatto changed the title Add missing remove add leader channel2 [NEW] Add missing remove add leader channel Feb 11, 2019
@MarcosSpessatto MarcosSpessatto mentioned this pull request Feb 11, 2019
Closed
@Montel
Copy link
Contributor Author

Montel commented Feb 12, 2019

I created this one #13445 (I hope that it's ok now :) )

@MarcosSpessatto MarcosSpessatto merged commit d7af7ea into RocketChat:develop Feb 18, 2019
@thayannevls thayannevls mentioned this pull request Feb 18, 2019
Closed
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Assignees
No one assigned
Labels
feat: api feat: rest
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Montel @MarcosSpessatto