Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View mode Compact no longer has timestamp and text on a single line #14322

Closed
krf opened this issue Apr 30, 2019 · 14 comments · Fixed by #15416
Closed

View mode Compact no longer has timestamp and text on a single line #14322

krf opened this issue Apr 30, 2019 · 14 comments · Fixed by #15416

Comments

@krf
Copy link

krf commented Apr 30, 2019

Description:

We just got upgraded to 1.0.1. The view mode setting inside the user preferences stopped working. If I understand correctly, then no matter what the setting is, "Normal" is used.

Steps to reproduce:

  1. Go to Profile -> My Account -> Preferences
  2. Set View Mode to "Compact"

Expected behavior:

View mode changes to "Compact" mode, which is one line per chat entry.

Actual behavior:

View mode stays at "Normal" mode, with separate lines for username/date and chat message.

Server Setup Information:

  • Version of Rocket.Chat Server: 1.0.1
  • Operating System: Linux
  • Number of Running Instances: Multiple
  • NodeJS Version: n/a
  • MongoDB Version: n/a
@krf
Copy link
Author

krf commented May 10, 2019

Bump? The current default view mode is eating up lots of vertical space...

@mvanbokhorst
Copy link

It seems that Compact is still a unique setting, as it shows multiple messages by the same user as different messages.
In Normal and Cozy these are consolidated into one.

I suspect that the problem is with view mode Compact no longer having timestamp and text on a single line, rather than view modes being ignored.

Some screenshots to show the differences.
Normal:
normal
Cozy:
cozy
Compact:
compact

@krf
Copy link
Author

krf commented May 15, 2019

I suspect that the problem is with view mode Compact no longer having timestamp and text on a single line, rather than view modes being ignored.

Right... And that combined with the fact it shows multiple messages by the same user as different messages does not really make it more "Compact" than any other view mode, does it? :)

@krf krf changed the title View mode setting ignored View mode Compact no longer has timestamp and text on a single line May 15, 2019
@krf
Copy link
Author

krf commented May 15, 2019

Thanks for the screenshots, by the way. Should/Could have done this myself... :)

@krf
Copy link
Author

krf commented May 27, 2019

Bump. Is anyone taking care of this?

@Sylordis
Copy link

Bumping this ticket, for the compact mode was very useful.

@ggazzo ggazzo added this to the 1.4.0 milestone Jul 23, 2019
@Exordian
Copy link
Contributor

Exordian commented Aug 24, 2019

Threading looks also quite broken on compact view.

i.e. gets notified that 'something happend' however there is no indication (or message) that a thread has been replied

@MartinSchoeler
Copy link
Contributor

@krf @mvanbokhorst Should it look something like this?

image

@mvanbokhorst
Copy link

mvanbokhorst commented Sep 18, 2019

That looks like the compact mode I had grown attached to.
A 'yes' from me!

@krf
Copy link
Author

krf commented Sep 18, 2019

👍

@Sylordis
Copy link

@MartinSchoeler without any spacing between paragraphs, new messages after the first at the beginning of the line, nickname is displayed only on the first message if in rapid succession, and edit icon at the beginning of the line (after nickname and if applicable). The one you're showing seems more like the "Cozy" version.

@MartinSchoeler MartinSchoeler self-assigned this Sep 18, 2019
@MartinSchoeler
Copy link
Contributor

@Sylordis About removing the spacing between paragraphs, that might cause problems, since you can add multiple paragraphs for spacing on a message, removing this could break a message that is desired to have spacing for formatting reasons.

@MartinSchoeler
Copy link
Contributor

I was thinking of something like this.
Screen Shot 2019-09-18 at 16 06 04

On multiline messages, I don't see the point on having the message on the first line, since the message will already disrupt the rest of the messages. And with the new organization of the message components, we would have to break it to add the first line of the multiline message to the side of the name and timestamp.

it might not be the most elegant solution, but In my opinion is better than the way that the old RC was doing it

Also the old behaviour did have the username/avatar on each message:
image

@Sylordis
Copy link

@MartinSchoeler Makes sense indeed for multi-line messages. When I said paragraphs, I meant messages, sorry: less spacing between two messages. I didn't have the nickname repeated though, and it was still last year. I mean... we know who's speaking by checking the first message.
I saw there were some css classes/styles which were hiding the nickname for following messages (or is it "non first messages"? I don't remember exactly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants