Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Threads doesn't hide the "Threads" button #14796

Closed
tassoevan opened this issue Jun 12, 2019 · 1 comment · Fixed by #14956
Closed

Disabling Threads doesn't hide the "Threads" button #14796

tassoevan opened this issue Jun 12, 2019 · 1 comment · Fixed by #14956
Projects
Milestone

Comments

@tassoevan
Copy link
Contributor

Description:

When disabling threads, the "Threads" button keeps showing on room actions bar (top right).

Steps to reproduce:

  1. Disable threads going into Administration > Threads > Enable and setting it to False.
  2. Open a room.

Expected behavior:

Do not see "Threads" button on the room actions bar.

Actual behavior:

The button is present. On clicking on it, the "Threads" tab is shown empty on the contextual bar and an error toast is triggered with "Not allowed" message.

Server Setup Information:

  • Version of Rocket.Chat Server: 1.2.0-develop
  • Operating System: MacOS Mojave
  • Deployment Method: source code
  • Number of Running Instances: 1
  • DB Replicaset Oplog: enabled
  • NodeJS Version: 8.11.4
  • MongoDB Version: 4.0.2

Additional context

Jun-12-2019 15-09-30

@tassoevan tassoevan added this to the 1.3.0 milestone Jun 12, 2019
@himpierre
Copy link

#14708

cesarmal added a commit to cesarmal/Rocket.Chat that referenced this issue Jul 10, 2019
@engelgabriel engelgabriel added the feat: threads / discussions Threads and Discussions label Jul 11, 2019
@sampaiodiego sampaiodiego modified the milestones: 1.3.0, 1.4.0 Jul 25, 2019
@theorenck theorenck added this to To do in 2.0.0 via automation Aug 16, 2019
@theorenck theorenck moved this from To do to Reviewer approved in 2.0.0 Aug 16, 2019
@theorenck theorenck moved this from Reviewer approved to Done in 2.0.0 Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants