-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebRTC echo while talking #15018
Comments
If you can make a connection then this is most likely down to your connection or other hardware/software/configuration related issues and not Rocket.Chat Please have a search on the interwebs for "voip echo" |
What Configuration you mean? Software configuration of any voip server or client has echo canselation, Vad or else. ThEn i start videochat from jitsi there are no echo.. so...
…--
Gerasim Shaverdov | Deputy CTO | Altarix
Mobile: +7 937 070 66 84<tel:+7%20937%20070%2066%2084> | Skype/email: gerasim@altarix.ru<mailto:gerasim@altarix.ru>
Lenina av.25, Samara, Russia, 443068
20 июля 2019 г., в 17:40, John Crisp <notifications@github.com<mailto:notifications@github.com>> написал(а):
If you can make a connection then this is most likely down to your connection or other hardware/software/configuration related issues and not Rocket.Chat
Please have a search on the interwebs for "voip echo"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#15018?email_source=notifications&email_token=AKOGQJX3GLXHI4DCV6DYIO3QAMIWFA5CNFSM4IFF44YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2NOQUQ#issuecomment-513468498>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKOGQJVQIWB4IGJSUCOGP63QAMIWFANCNFSM4IFF44YA>.
|
have the same problem too Version 1.2.1 |
I can reproduce on Windows, Mac and Linux. |
We too have it. Can reproduce on Windows 7 and 10. Is there a fix for this? Version 1.3.2 |
Same issue, both in client and in webinterface. |
I can confirm the issue in web interface with One to One and One to many users across different zones. |
Same issue :/ |
Version 2.1.1 – still echo on any webrtc
…--
Gerasim Shaverdov | Deputy CTO | Altarix
Mobile: <tel:+7%20937%20070%2066%2084> +7 937 070 66 84 | Skype/email: <mailto:gerasim@altarix.ru> gerasim@altarix.ru
Lenina av.25, Samara, Russia, 443068
From: arslan95 <notifications@github.com>
Sent: Thursday, October 24, 2019 3:24 PM
To: RocketChat/Rocket.Chat <Rocket.Chat@noreply.github.com>
Cc: Шавердов Герасим Сергеевич <gerasim@altarix.ru>; Author <author@noreply.github.com>
Subject: Re: [RocketChat/Rocket.Chat] WebRTC echo while talking (#15018)
Same issue :/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#15018?email_source=notifications&email_token=AKOGQJROYRBKSC3PQ4DGIIDQQGAUNA5CNFSM4IFF44YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEVYVY#issuecomment-545872983> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKOGQJVC3PSKVEJ4ZSNIQPTQQGAUNANCNFSM4IFF44YA> .
|
Still hearing the echo on 2.3.1 |
Yeah this isn't the users hardware, You need to mute the local audio stream. You are playing the users local audio input back to them along with the audio output. This is a common mistake with webrtc implementation. Even if one person mutes, the other person hears themself talk. https://stackoverflow.com/questions/18406193/how-to-avoid-echo-and-noise-in-javascript-for-webrtc |
Unforutnately there's no way to fix this from the current version of the ui. You'd have to hack it with extra JS or wait for the dev team to fix the Rocketchat issue here. |
To be clear this is not an echo. It is the audio input stream being played back to the sender. The only time the local video should be unmuted is when the user is doing a microphone check in a diagnostic window. |
Its call - echo;)) all that you explained;) user who hear echo get it on hiself side:)
…--
Gerasim Shaverdov | Deputy CTO | Altarix
Mobile: +7 937 070 66 84 | Skype/email: gerasim@altarix.ru
Lenina av.25, Samara, Russia, 443068
20 дек. 2019 г., в 1:01, Chris Routh ***@***.***> написал(а):
To be clear this is not an echo. It is the audio input stream being played back to the sender.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This isn't echo in my case. Echo is when your voice exits the other persons speaker and is picked up by their mic, feeding back to you via their audio. If the other person mutes their mic or I mute them, I can hear myself. I hear myself louder and clearer than the other person. That's not echo, it's the local audio stream. |
Now clear to understood
…--
Gerasim Shaverdov | Deputy CTO | Altarix
Mobile: +7 937 070 66 84 | Skype/email: gerasim@altarix.ru
Lenina av.25, Samara, Russia, 443068
21 дек. 2019 г., в 7:28, Chris Routh ***@***.***> написал(а):
This isn't echo in my case. Echo is when your voice exits the other persons speaker and is picked up by their mic, feeding back to you via their audio.
If the other person mutes their mic or I mute them, I can hear myself. I hear myself louder and clearer than the other person. That's not echo, it's the local audio stream.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Workaround in FIrefox:
|
Possible solution in RocketChat: |
Already trying.. no effect, still echo
Отправлено с iPhone
… 11 марта 2020 г., в 20:25, J. Stebens ***@***.***> написал(а):
Workaround in FIrefox:
Right click on the video element and choose show controls
Either use the audio slider to reduce volume to 0 or click on the sound icon to mute/unmute the element
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Updated workaround description to clarify which mute is meant (to many mutes available) |
in desktop this does not show, in web is tu bugged |
Having a fix to this annoying issue would be awesome. Particularly with the pandemic going on, we need more audio contact with fellow coworkers :) Thanks ! |
No pandemic. Only artificial panic;)! Use jitsi instead. Ot may work localy
Отправлено с iPhone
… 16 марта 2020 г., в 12:49, Benjamin Guillon ***@***.***> написал(а):
Having a fix to this annoying issue would be awesome.
Particularly with the pandemic going on, we need more audio contact with fellow coworkers :)
Thanks !
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Ok will try again with Jitsi, but I recall we encountered other issues there. We got stuck on remote work anyway so ... :) Gotta make it work. Thanks! |
If anyone wants to help fix this i'm willing to fund your work. Feel free to ping me. |
We need a way to make the team acknowledge and prioritize this issue. In my understanding this issue is not really acknowledged yet. It have a direct impact for many on their choice to use Rocket Chat. @sampaiodiego |
So i actually fixed it, i'll submit a PR to address it for everyone else (tomorrow?). |
@ndroo Thanks for helping out, that's surely going to help! |
can you share with me how you did? |
Hi, I have the same problem ans it's so difficult to find any documentation about WebRtc configuration on rocket.chat. Regards |
Have you any solution? |
Yesterday I installed our new rocket.chat server but we are facing with the same problem and we can't start to use it till this problem will be not solved. As I see ndroo mentioned that he fixed the issue but I don't find any related description. I tested the BETA version too but it has the same problem. Any fix for this? "So i actually fixed it, i'll submit a PR to address it for everyone else (tomorrow?)." - 9 days ago Was this fix published somewhere? |
:) man everyones after me. Sorry, big push on our side trying to support others working remote right now. PR coming shortly... |
@ndroo you're officially promoted to the rank of Super Hero 🍾 ! Thank you for your contribution! O7 |
Hi, I don't find the file videocall.html on my rocketchat 3.0.9... My installation is on /opt/rocketchat and do not have this file... Where is it? Regards |
Description:
When make audio call via webrtc on desktop client there are some echo on both side
Steps to reproduce:
Expected behavior:
We do not hear any echo as as-self voice
Actual behavior:
we hear selfs echo
Server Setup Information:
The text was updated successfully, but these errors were encountered: