Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebRTC echo while talking #15018

Closed
Shaverdoff opened this issue Jul 19, 2019 · 35 comments · Fixed by #17145
Closed

WebRTC echo while talking #15018

Shaverdoff opened this issue Jul 19, 2019 · 35 comments · Fixed by #17145
Labels
feat: webrtc squad: video conferencing stat: triaged Issue reviewed and properly tagged type: bug
Milestone
3.1.0

Comments

@Shaverdoff
Copy link

Description:

When make audio call via webrtc on desktop client there are some echo on both side

Steps to reproduce:

  1. Login to RC
  2. Choose buddy to make audiocall
  3. Hear you-self voice

Expected behavior:

We do not hear any echo as as-self voice

Actual behavior:

we hear selfs echo

Server Setup Information:

  • Version of Rocket.Chat Server: 1.2.1
  • Operating System: Centos 7
  • Deployment Method: docker
  • Number of Running Instances: 3
  • DB Replicaset Oplog: yes
  • NodeJS Version: 8.11.4
  • MongoDB Version: 3.6
@reetp
Copy link

reetp commented Jul 20, 2019

If you can make a connection then this is most likely down to your connection or other hardware/software/configuration related issues and not Rocket.Chat

Please have a search on the interwebs for "voip echo"

@Shaverdoff
Copy link
Author

Shaverdoff commented Jul 21, 2019 via email

@MrOplus
Copy link

MrOplus commented Jul 31, 2019

have the same problem too

Version 1.2.1
Apps Engine Version 1.4.2
OS : Ubuntu 19

@franckadil
Copy link

franckadil commented Sep 16, 2019 •
edited

I can reproduce on Windows, Mac and Linux.

@JohnnyRahul
Copy link

JohnnyRahul commented Oct 15, 2019 •
edited

We too have it. Can reproduce on Windows 7 and 10. Is there a fix for this?

Version 1.3.2
Apps Engine Version - 1.5.2
OS - Windows 7

@moofen
Copy link

moofen commented Oct 18, 2019

Same issue, both in client and in webinterface.

@franckadil
Copy link

I can confirm the issue in web interface with One to One and One to many users across different zones.

@arslan95
Copy link

Same issue :/

@Shaverdoff
Copy link
Author

Shaverdoff commented Oct 24, 2019 via email

@lightweight
Copy link

Still hearing the echo on 2.3.1

@Routhinator
Copy link

Yeah this isn't the users hardware, You need to mute the local audio stream. You are playing the users local audio input back to them along with the audio output. This is a common mistake with webrtc implementation. Even if one person mutes, the other person hears themself talk.

https://stackoverflow.com/questions/18406193/how-to-avoid-echo-and-noise-in-javascript-for-webrtc

@Routhinator
Copy link

Unforutnately there's no way to fix this from the current version of the ui. You'd have to hack it with extra JS or wait for the dev team to fix the Rocketchat issue here.

@Routhinator
Copy link

Routhinator commented Dec 19, 2019 •
edited

To be clear this is not an echo. It is the audio input stream being played back to the sender.

The only time the local video should be unmuted is when the user is doing a microphone check in a diagnostic window.

@Shaverdoff
Copy link
Author

Shaverdoff commented Dec 19, 2019 via email

@Routhinator
Copy link

This isn't echo in my case. Echo is when your voice exits the other persons speaker and is picked up by their mic, feeding back to you via their audio.

If the other person mutes their mic or I mute them, I can hear myself. I hear myself louder and clearer than the other person. That's not echo, it's the local audio stream.

@Shaverdoff
Copy link
Author

Shaverdoff commented Dec 21, 2019 via email

@konsumate
Copy link
Contributor

konsumate commented Mar 11, 2020 •
edited

Workaround in FIrefox:

  • Right click on YOUR video element in the BOTTOM in the video pane collection and choose show controls OR directly mute the video in the popup menu.
  • Now either use the audio slider to reduce volume to 0 or click on the sound icon of YOUR video element to mute/unmute the element (not the microphone button below)

mute

@konsumate
Copy link
Contributor

konsumate commented Mar 11, 2020 •
edited

Possible solution in RocketChat:
Simply deliver the video element ON THE BOTTOM with muted="muted" element or any other sane and proper way to muted the sound of the video element

@Shaverdoff
Copy link
Author

Shaverdoff commented Mar 11, 2020 via email

@konsumate
Copy link
Contributor

Updated workaround description to clarify which mute is meant (to many mutes available)

@Shaverdoff
Copy link
Author

in desktop this does not show, in web is tu bugged

@Bengrunt
Copy link

Having a fix to this annoying issue would be awesome.

Particularly with the pandemic going on, we need more audio contact with fellow coworkers :)

Thanks !

@Shaverdoff
Copy link
Author

Shaverdoff commented Mar 16, 2020 via email

@Bengrunt
Copy link

No pandemic. Only artificial panic;)! Use jitsi instead. Ot may work localy Отправлено с iPhone
…
16 марта 2020 г., в 12:49, Benjamin Guillon @.***> написал(а):  Having a fix to this annoying issue would be awesome. Particularly with the pandemic going on, we need more audio contact with fellow coworkers :) Thanks ! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Ok will try again with Jitsi, but I recall we encountered other issues there.

We got stuck on remote work anyway so ... :) Gotta make it work.

Thanks!

@ndroo
Copy link
Contributor

ndroo commented Mar 21, 2020

If anyone wants to help fix this i'm willing to fund your work. Feel free to ping me.

@franckadil
Copy link

We need a way to make the team acknowledge and prioritize this issue. In my understanding this issue is not really acknowledged yet. It have a direct impact for many on their choice to use Rocket Chat. @sampaiodiego

@ndroo
Copy link
Contributor

ndroo commented Mar 23, 2020

So i actually fixed it, i'll submit a PR to address it for everyone else (tomorrow?).

@franckadil
Copy link

@ndroo Thanks for helping out, that's surely going to help!

@douglasmcqoy
Copy link

So i actually fixed it, i'll submit a PR to address it for everyone else (tomorrow?).

can you share with me how you did?

@franckadil franckadil mentioned this issue Mar 29, 2020
Closed
@PatAgglo
Copy link

Hi,

I have the same problem ans it's so difficult to find any documentation about WebRtc configuration on rocket.chat.
If you have any solution for this, I am interested!

Regards

@PatAgglo
Copy link

If anyone wants to help fix this i'm willing to fund your work. Feel free to ping me.

Have you any solution?

@kvasko
Copy link

kvasko commented Apr 1, 2020 •
edited

Yesterday I installed our new rocket.chat server but we are facing with the same problem and we can't start to use it till this problem will be not solved. As I see ndroo mentioned that he fixed the issue but I don't find any related description. I tested the BETA version too but it has the same problem. Any fix for this?

"So i actually fixed it, i'll submit a PR to address it for everyone else (tomorrow?)." - 9 days ago

Was this fix published somewhere?

@ndroo
Copy link
Contributor

ndroo commented Apr 2, 2020

:) man everyones after me. Sorry, big push on our side trying to support others working remote right now. PR coming shortly...

ndroo added a commit to ndroo/Rocket.Chat that referenced this issue Apr 3, 2020
@ndroo
[Fix] Update WebRTC components to address RocketChat#15018
f814a95
@ndroo ndroo mentioned this issue Apr 3, 2020
Merged
@franckadil
Copy link

@ndroo you're officially promoted to the rank of Super Hero 🍾 ! Thank you for your contribution! O7

@PatAgglo
Copy link

PatAgglo commented Apr 3, 2020 •
edited

Hi,

I don't find the file videocall.html on my rocketchat 3.0.9...

My installation is on /opt/rocketchat and do not have this file...

Where is it?

Regards

@engelgabriel engelgabriel added this to the 3.1.0 milestone Apr 3, 2020
@Marcel2508 Marcel2508 mentioned this issue Mar 24, 2022
Closed
@codingsplash codingsplash mentioned this issue Jun 2, 2022
Open
@miraz00 miraz00 mentioned this issue Feb 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat: webrtc squad: video conferencing stat: triaged Issue reviewed and properly tagged type: bug
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

[FIX] WebRTC echo while talking ndroo/Rocket.Chat