Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too easy to accidentally leave channels #1543

Closed
gwillen opened this issue Dec 2, 2015 · 14 comments · Fixed by #2113
Closed

Too easy to accidentally leave channels #1543

gwillen opened this issue Dec 2, 2015 · 14 comments · Fixed by #2113

Comments

@gwillen
Copy link

gwillen commented Dec 2, 2015

I and my coworkers have been finding that it's too easy to accidentally leave a channel in Rocket. The 'exit' button is right inside the channel bar where one would naturally click to view the channel, it's at the far right end which is a natural place to click to bring the channel up, AND it doesn't appear until your mouse is right on top of it, so you don't realize you're going to hit it.

This is especially bad with private channels, where you can accidentally remove yourself with one click and it's not possible to undo. (This is made double-extra bad by #1414 which means that you can't even get someone else from the channel to invite you back in -- if the channel owner is on a two-week vacation, say, you're REALLY screwed.)

Leaving a private channel should DEFINITELY require confirmation since you cannot undo it. Leaving any channel should probably take more than one click, but it's not as urgent. (On Slack, leaving a channel is in the channel menu, it's not available in the main view at all -- this makes sense to me because it's not something you'd expect to do frequently.)

Thanks!

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@gwillen
Copy link
Author

gwillen commented Dec 2, 2015

Update: I'm not even making this up, I didn't do this on purpose: The creator of a private channel just accidentally left it. Now we seem to be really stuck because nobody has invite powers... what do we do :-(

@rustyrussell
Copy link

+1. I just tried to click on the [1] notification number to dismiss it (despite multiple scrollback, it didn't clear), and left my own private group! So, +1 from me while I unscrew myself.

@marceloschmidt
Copy link
Member

I completely agree! Let's have the leave room in the channel settings tab, what do you think? Also, re-assigning ownership of the room to the oldest user in room when the owner leaves would be a plus, huh?

@graywolf336
Copy link
Contributor

@marceloschmidt Both of those sound good to me. The leave room in the channel settings tab will pave the way for using it to promote people to channel moderators (if we get to that eventually), channel notifications preferences, and maybe other things as well.

@marceloschmidt
Copy link
Member

Yes! And we'll call that Channel Info instead of Channel Settings. Makes more sense.

@graywolf336
Copy link
Contributor

👍 even display who the current channel owner is just for having that information there.

@richardwlu
Copy link

👍

@soenkef
Copy link
Contributor

soenkef commented Dec 11, 2015

I'm new here and I'm excited testing rocket.chat. I''ve installed my own rocket server and tried many features. It makes me crazy leaving my own room. In this case the next member in that group may be chosen as new admin with rights to add users.

@rockneverdies55
Copy link

👍

@fduraibi
Copy link
Contributor

fduraibi commented Jan 2, 2016

👍

i just clicked on the Unread counter, and poof.... :(

acc-bug3

@magro
Copy link

magro commented Feb 2, 2016

+1

@graywolf336
Copy link
Contributor

Should we move this to the settings tab of the channel?

On Tue, Feb 2, 2016, 8:27 AM Martin Grotzke notifications@github.com
wrote:

+1


Reply to this email directly or view it on GitHub
#1543 (comment)
.

@soenkef
Copy link
Contributor

soenkef commented Feb 2, 2016

It would be great when you would be asked and must confirm whean leaving the channel or group. I think it is a feature for templates.

@magro
Copy link

magro commented Feb 2, 2016

Yes, a confirmation would be great. The same applies to "hide room". Moving these options to the settings tab might be a pragmatic solution if it's much easier than adding the confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants