Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom sound form submits even without adding a file #21664

Closed
PriyaBihani opened this issue Apr 20, 2021 · 1 comment
Closed

Add custom sound form submits even without adding a file #21664

PriyaBihani opened this issue Apr 20, 2021 · 1 comment

Comments

@PriyaBihani
Copy link
Contributor

Description:

When we try to add a custom sound in admin panel, the submit button gets enabled as soon as we enter a name. Making it possible for user to submit without uploading a file which results in an error "can not read property name of undefined".

Steps to reproduce:

  1. Go to the admin panel
  2. Go to custom sounds
  3. Try to add a custom sound without name.

Expected behaviour:

Submit button should remain disabled until both name and file is added.

Actual behavior:

Button gets enabled as soon as a name is added thus making it possible to submit form.
Screenshot 2021-04-20 at 3 55 06 PM

Server Setup Information:

  • Version of Rocket.Chat Server:
  • Operating System:
  • Deployment Method:
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version:

Client Setup Information

  • Desktop App or Browser Version:
  • Operating System:

Additional context

Relevant logs:

@dougfabris
Copy link
Member

Recently we did some refactoring in this section (#25128) and we added validation for the empty file as well.
Thanks a lot for your help @PriyaBihani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants