Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable or filter object embed - admin / settings #225

Closed
Sing-Li opened this issue Jun 25, 2015 · 2 comments
Closed

Add ability to disable or filter object embed - admin / settings #225

Sing-Li opened this issue Jun 25, 2015 · 2 comments

Comments

@Sing-Li
Copy link
Member

Sing-Li commented Jun 25, 2015

Object embed is a source of bots-net styled Denial of Service attacks for chat based systems

For the admin / settings page, it would be nice to have:

  1. setting to disable embed altogether
  2. setting to replace iFramely oembed with simple-embed (we may not have access to item 3 with iFramely)
  3. setting to configure [access, deny] filter rules for "after embed transforms", "before render", URLs

item 3 is likely a pre-requisite for corporate installs

@engelgabriel
Copy link
Member

See #230

@nevson nevson mentioned this issue Jun 29, 2015
11 tasks
@engelgabriel
Copy link
Member

Depends on #222

@engelgabriel engelgabriel added this to the v1.0 milestone Jun 30, 2015
@rodrigok rodrigok modified the milestones: v1.0, Next Aug 15, 2015
@rodrigok rodrigok modified the milestones: Next, v1.0 Aug 19, 2015
tkurz pushed a commit to redlink-gmbh/Rocket.Chat that referenced this issue Mar 13, 2018
…-custom-roomtypes-icon

The function is already used to pick the icon in the side nav
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants