Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some links' title not escaped well #2338

Closed
kxxoling opened this issue Feb 25, 2016 · 0 comments · Fixed by #2756
Closed

Some links' title not escaped well #2338

kxxoling opened this issue Feb 25, 2016 · 0 comments · Fixed by #2756
Assignees
@rodrigok
Labels
feat: embed type: bug
Milestone
0.25.0

Comments

@kxxoling
Copy link
Contributor

eg.

chat

Middle dash - in the title is not well escaped.

Links are: http://fabric-chs.readthedocs.org/zh_CN/chs/ and https://bitbucket.org/bxzz/
@engelgabriel engelgabriel added this to the 0.25.0 milestone Mar 23, 2016
marceloschmidt added a commit that referenced this issue Apr 4, 2016
@marceloschmidt
Show URL attributes after applying Handlebars.SafeString; Fix #2338
0a1c44e
@marceloschmidt marceloschmidt mentioned this issue Apr 4, 2016
Merged
engelgabriel pushed a commit that referenced this issue Apr 4, 2016
@marceloschmidt @engelgabriel
Show URL attributes after applying Handlebars.SafeString
c1c0867 
* Show URL attributes after applying Handlebars.SafeString; Fix #2338

* Check if string before applying safestring.
This was referenced Jan 16, 2022
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigok rodrigok

Labels
feat: embed type: bug
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

Show URL attributes after applying Handlebars.SafeString RocketChat/Rocket.Chat
4 participants
@rodrigok @engelgabriel @kxxoling @sampaiodiego