Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Emoji library #24917

Open
matthias4217 opened this issue Mar 23, 2022 · 37 comments · May be fixed by #27782
Open

Update Emoji library #24917

matthias4217 opened this issue Mar 23, 2022 · 37 comments · May be fixed by #27782
Labels
contrib: good first issue Issues that you can solve to start contributing :) hacktoberfest ui/ux

Comments

@matthias4217
Copy link
Contributor

Description:

Currently, emojis in the emoji picker are limited to Emoji 12. The current set seem to be the one in the npm package emojione (emojione-assets in the dev dependencies). However, this project has been discontinued due to a change of name. It should be replaced by the newer emoji-toolkit package. See more about it in this Readme.

This is of course a minor issue, but I figure it can also be quite easy to fix. Thank you for your time and attention !

Steps to reproduce:

Search for an Emoji 12 or newer emoji, such as 🪓.

Expected behavior:

I would like to have a more up-to-date version.

Actual behavior:

There is no 🪓 in the emoji picker.

Server Setup Information:

  • Version of Rocket.Chat Server: 4.5.1
  • Operating System: Varies
  • Deployment Method: Docker
  • Number of Running Instances: 4
  • DB Replicaset Oplog:
  • NodeJS Version: v14.18.3
  • MongoDB Version:5.0.3

Client Setup Information

  • Desktop App or Browser Version: Both
  • Operating System: Ubuntu 20.04
@dudanogueira dudanogueira added the contrib: good first issue Issues that you can solve to start contributing :) label Mar 23, 2022
@mpgent
Copy link

mpgent commented Mar 23, 2022

I'd like to work on this issue

@ankar84
Copy link

ankar84 commented Mar 24, 2022

Nice to see new updated emojis in Rocket Chat!

@Zishan-7
Copy link

Hey! I would love to work on this issue.

@meerhamzadev
Copy link

meerhamzadev commented Mar 25, 2022

Is this issue still available? I would like to give it a try.

@matthias4217
Copy link
Contributor Author

This issue is still opened indeed. Feel free to make a pull request I guess !

@Illusion47586
Copy link

Hello @matthias4217 I would like to work on this issue

@aliubaidsaifi
Copy link

Hello @matthias4217 I would like to work on this issue please assign it to me.

@matthias4217
Copy link
Contributor Author

Hello @matthias4217 I would like to work on this issue please assign it to me.

Hello, I am not a RocketChat maintainer. Feel free to contribute. @kotwani2883 has already opened the PR #25131 but it hasn't been reviewed yet.

@adityajangir
Copy link

Hello @matthias4217 , Could you please assign this issue to me.

@matthias4217
Copy link
Contributor Author

Hello @matthias4217 , Could you please assign this issue to me.

Hello, I am not a RocketChat maintainer. I cannot assign anyone to it, you're absolutely free to open a Pull Request to work on this issue !

@kartikbh6614
Copy link

I want to work on this issues please assign me this issue .

@MrVSiK MrVSiK linked a pull request Jan 17, 2023 that will close this issue
@21SINGH
Copy link

21SINGH commented Jan 21, 2023

this is my first time here i pushed a commit request , but its showing review required , i dont understand a thing what's going on can anyone please explaine its like that since yesterday

@anikdhabal
Copy link
Contributor

@21SINGH your code required review before merge into the project. Reviews allow collaborators to comment on the changes in pull your requests, approve the changes, or request further changes before the pull request is merged. Repository administrators can require that all pull requests are approved before being merged.

@21SINGH
Copy link

21SINGH commented Jan 21, 2023

@anikdhabal
so then who will review it
if the administrator is going to do it , then when will he do it
because i posted it yesterday

@seniorLikeToCode
Copy link

hi I want to contribute to this , assign me this issue.

@LovedeepSingh19
Copy link

hi I need some help with this issue. When ever i try to update the import emojione to emoji-toolkit it shows no library found. I try to install it with meteor and it get installed but in the end whenever i try to run yarn dev it just keep on crashing the application can anyone help me with this one plz.

@MashiatK
Copy link

MashiatK commented Feb 6, 2023

hi I want to contribute to this , assign me this issue please.

@VaibhavAPatil
Copy link

I am interested in this Issue. Can I do Pull Request or you can assign this issue to Me.

@nikhil-babar
Copy link

I am interested in solving this issue and can add this new dependency. Please can you assign me this issue.

@dsg1320
Copy link

dsg1320 commented Feb 16, 2023

Hey can you please assign this issue

@sachinrastogi12
Copy link

Hey please assign it to me, I want to contribute.

@B1TSH3LL
Copy link

if the issue isn't solved yet, please assign this to me. i would work on this issue.

@thekrprince
Copy link

Hi, Please assign this issue to me. I want to contribute.

@Jashwanthkanderi
Copy link

does anyone working on this issue cause I can contribute to it @matthias4217

@matthias4217
Copy link
Contributor Author

@Jashwanthkanderi There’s a merge request opened here (#27782) but it hasn’t been accepted yet.

@Jashwanthkanderi
Copy link

@Jashwanthkanderi There’s a merge request opened here (#27782) but it hasn’t been accepted yet.

Yeah i don't know why it's been 10+ hrs I think it should be correct , but I may solve this issue

@KshitjMaheshwari
Copy link

Hi Please assign this to me. I want to contribute.

@adastra-react
Copy link

Hey, I would really like to work on this issue, this is my first time getting into open source.

Amdadullah-Raihan added a commit to Amdadullah-Raihan/Rocket.Chat that referenced this issue May 24, 2023
@ranjanmangla1
Copy link

Hey, if this issue is still open, i would really love to work on this issue. Kindly assign me this issue.

@matthias4217
Copy link
Contributor Author

@ranjanmangla1 You don’t need to be assigned on it to work on this issue. This comment also gives some advice. ^^

Daksh-10 added a commit to Daksh-10/Rocket.Chat that referenced this issue Aug 9, 2023
Dnouv added a commit to Daksh-10/Rocket.Chat that referenced this issue Aug 23, 2023
@auspy
Copy link

auspy commented Aug 28, 2023

starting working on this issue

Daksh-10 added a commit to Daksh-10/Rocket.Chat that referenced this issue Sep 1, 2023
@SyedAbuBakerAli
Copy link

Hi, @matthias4217 is this issue still open I want to work on this issue.
Can you please assign this to me?

@nick2432
Copy link

nick2432 commented Oct 3, 2023

can i work on this?

Simer13 added a commit to Simer13/Rocket.Chat that referenced this issue Oct 16, 2023
Updated the word "emojione" with the word "emoji-toolkit" in all the files in the codebase.
Simer13 added a commit to Simer13/Rocket.Chat that referenced this issue Oct 16, 2023
Updated the word "emojione" with the word "emoji-toolkit" in all the files in the codebase.
@devr77
Copy link

devr77 commented Oct 27, 2023

@dudanogueira @matthias4217 Is this issue solved, Please Reply

@SwapnilSonker
Copy link

is this issue fixed by #27782, if not then I want to fix it.

@Asrani-Aman
Copy link

@matthias4217 is this issue fixed? or else I can work on it?

@meenakshiiyer2531
Copy link

Is the issue fixed? if not I would like to work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contrib: good first issue Issues that you can solve to start contributing :) hacktoberfest ui/ux
Projects
None yet