Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Avatars switch: unable to disable showing avatars in messages #26741

Closed
vnavna01 opened this issue Aug 30, 2022 · 25 comments · Fixed by #27072
Closed

Display Avatars switch: unable to disable showing avatars in messages #26741

vnavna01 opened this issue Aug 30, 2022 · 25 comments · Fixed by #27072
Labels
contrib: good first issue Issues that you can solve to start contributing :) hacktoberfest type: bug type: regression

Comments

@vnavna01
Copy link

User Preference:
Display Avatars: Hides avatars on the channels, showing only the users' usernames.

This setting since version 5 does not disable the viewing of user's avatars in messages.
@dudanogueira
Copy link
Contributor

Hi! Thanks for pointing out. Another user also pointed it here:
https://forums.rocket.chat/t/various-settings-not-saved-after-rc-server-upgrade/15075/17

i will raise awareness internally. THanks!

@dudanogueira dudanogueira added bug contrib: good first issue Issues that you can solve to start contributing :) labels Oct 13, 2022
@drewch34
Copy link

@dudanogueira - Howdy - I wouldn't mind working on this issue if it hasn't been assigned. :)

@nishant23122000 nishant23122000 mentioned this issue Oct 14, 2022
Merged
@tassoevan tassoevan added type: bug and removed bug labels Oct 26, 2022
@tejaskh3
Copy link

Hii am new to open source please assign this issue to me.

@kunals131
Copy link

I want to work on this issue, please assign me.

@Srishti-j18
Copy link

I am very interested in this issue. Can you please assign me this issue?

@akash19coder
Copy link

akash19coder commented Jan 25, 2023 •
edited

@dudanogueira I have gone through https://developer.rocket.chat/rocket.chat/rocket-chat-environment-setup/gitpod and set up everything on my computer. I am not sure where should I begin in order to resolve this issue so could you please help me out? I am struggling to find the find the folder where code for this is written

@akash19coder
Copy link

akash19coder commented Jan 25, 2023 •
edited

@dudanogueira

When the Display Avatar is toggled on

displayOn
Avatar appears which indeed is right
display

When Display toggle is off

displayOFf
Avatar still appears instead of not appearing
display2

Is this what needs to fixed in this issue

@akash19coder
Copy link

@dudanogueira I play around with the codebase and found out the piece of code related to this issue.
handleDisplayAvatar

I am struggling to find the implementation of this function. Please help

@Abhishek7Tech
Copy link

@akash19coder Hi,
have you managed to solve the issue?

@akash19coder
Copy link

@Abhishek7Tech Nope, not yet I am struggling to find out the message component

@ShadyResurrected
Copy link

Can i be assigned this issue?

@Keerthivardhan1
Copy link

I Have tried this .. its working fine .
i think this issue was resolved
Screenshot 2023-02-04 231052
I have disabled avatars

@depleur
Copy link

depleur commented Feb 9, 2023

@Keerthivardhan1 The avatar is still showing though. I don't think the issue is resolved yet.

@roy9495
Copy link

roy9495 commented Feb 13, 2023

Is this the solutionrocket_chat

@depleur
Copy link

depleur commented Feb 14, 2023

@roy9495 Yes, I think that works.

@roy9495 roy9495 mentioned this issue Feb 16, 2023
Closed
@shashank-jain2605
Copy link

Hi, If this issue is open, please assign it to me.
I would like to contribute.

@Sandhya58
Copy link

Hello, I can see the issue is still open. I can resolve this issue, please assign it to me.

@dudanogueira
Copy link
Contributor

great work on #28069 @roy9495 !!

Thanks!

@roy9495
Copy link

roy9495 commented Feb 27, 2023

great work on #28069 @roy9495 !!

Thanks!

Thank younsir

@ASHUTOSH-309
Copy link

Oct 13, 2022

HOW DO YOU CHECK WHETHER AVATAR IS STILL SHOWING UP OR NOT. I AM NEW PLEASE HELP

@B1TSH3LL
Copy link

i want to work on this issue please assign this to me.!

@kodiakhq kodiakhq bot closed this as completed in #27072 Mar 15, 2023
@gabepettus
Copy link

gabepettus commented Mar 16, 2023 •
edited

Issue is not fixed (don't mind the dates the conversation was very old)
rocketchat

[Rocket.Chat Desktop] waiting for window load
f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:5 fuselage: 0.31.22
f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1583 MessageType.render is deprecated. Use MessageType.message instead. livechat_webrtc_video_call
registerType @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1583
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1583
g @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
a @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:5
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1583
g @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
a @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:5
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1583
g @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
a @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:5
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1583
g @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
t @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
(anonymous) @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1583
f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1046 strict mode: use allowUnionTypes to allow union type keyword at "#/properties/value" (strictTypes)
w @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1046
U @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
L @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
R @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
T @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
C @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
E @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
A @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
subschema @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
m @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1049
code @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1049
V @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
(anonymous) @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
code @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1046
block @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1046
F @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
g @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
(anonymous) @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
code @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1046
block @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1046
T @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
C @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
(anonymous) @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
code @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1046
(anonymous) @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
code @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1046
func @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1046
g @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
x @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
b @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
l @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1046
_compileSchemaEnv @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
compile @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
e @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
g @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
t @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
e @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1043
g @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
a @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:5
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1583
g @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
a @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:5
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1583
g @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
a @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:5
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1583
g @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
n @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
t @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:3
(anonymous) @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1583
f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1336 WebSocket connection to 'wss://chat.corp.icr-team.com/sockjs/170/20ienyze/websocket' failed: Error during WebSocket handshake: Unexpected response code: 400
k.websocket @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1336
k._try_next_protocol @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1336
k._didClose @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1336
o._ir.onfinish @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1336
i.emit @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1336
i.onfinish @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1336
i.emit @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1336
s.xhr.onreadystatechange @ f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1336
preload.ts:26 [Rocket.Chat Desktop] preload.ts start
injected.ts:9 [Rocket.Chat Desktop] Injected.ts
injected.ts:259 [Rocket.Chat Desktop] Injected
injected.ts:12 [Rocket.Chat Desktop] Injected.ts start fired
injected.ts:28 [Rocket.Chat Desktop] Injected.ts serverInfo {version: '5.4.4', build: {…}, marketplaceApiVersion: '1.36.0', commit: {…}}build: {date: '2023-03-08T21:50:40.534Z', nodeVersion: 'v14.19.3', arch: 'x64', platform: 'linux', osRelease: '5.15.0-1033-azure', …}commit: {hash: '287559c6df05bb886f4654bc86f6ca20e646f526', date: 'Wed Mar 8 18:39:53 2023 -0300', author: 'Diego Sampaio', subject: 'Merge pull request #28333 from RocketChat/release-5.4.4', tag: '5.4.4', …}marketplaceApiVersion: "1.36.0"version: "5.4.4"[[Prototype]]: Object
gitCommitHash.ts:9 setGitCommitHash 287559c
injected.ts:129 [Rocket.Chat Desktop] Injected.ts replaced Notification
preload.ts:46 [Rocket.Chat Desktop] waiting for RocketChatDesktop.onReady
preload.ts:48 [Rocket.Chat Desktop] RocketChatDesktop.onReady fired
f9b04a39f9795b74dad42d01413bd9afffafddcd.js?meteor_js_resource=true:1583 Error loading moment locale: r {isClientSafe: true, error: 'Moment locale not found: 2 [moment-locale-not-found]', reason: 'Moment locale not found: 2', details: undefined, message: 'Moment locale not found: 2 [Moment locale not found: 2 [moment-locale-not-found]]', …}

DeepankCod added a commit to DeepankCod/gsoc-good-first-issues that referenced this issue Mar 20, 2023
@DeepankCod
Updated README.md
992eb07 
Removed closed/resolved issues :
sugarlabs/musicblocks#3175
RocketChat/Rocket.Chat#26741
Submitty/Submitty#8919
Submitty/Submitty#7027
oppia/oppia#17074
@DeepankCod DeepankCod mentioned this issue Mar 20, 2023
Open
@mdkaifansari04
Copy link

If the issue is still pending I'll be glad to fix it .

@Shibn2
Copy link

Shibn2 commented Jul 12, 2023

If the issue is still pending, I 'd like contribute.

@dougfabris
Copy link
Member

dougfabris commented Jul 20, 2023 •
edited

@gabepettus it was fixed and it's available on the 6.2.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib: good first issue Issues that you can solve to start contributing :) hacktoberfest type: bug type: regression
Projects
None yet
Milestone
No milestone