Administration > Workspace is visible for usual users

[krenuser]

Description:

Administration > Workspace menu item is visible and available for usual users, though contents of this page are not loading:

Steps to reproduce:

1. Login as usual user on RC 5.2.0
2. Open Administration > Workspace menu item

Expected behavior:

Neither Administration, nor Administration > Workspace item should not be visible to usual users.

Actual behavior:

Menu item is visible for usual users, contents of opened page aren't loading.

Server Setup Information:

• Version of Rocket.Chat Server: 5.2.0
• Operating System: Linux Ubuntu 20.04
• Deployment Method: docker
• Number of Running Instances: 1
• DB Replicaset Oplog: Enabled
• NodeJS Version: v14.19.3
• MongoDB Version: 5.0.13 / wiredTiger

Client Setup Information

• Desktop App or Browser Version: Desktop 3.8.12 / Browser
• Operating System: Windows 10

Additional context

none

Relevant logs:

No relevant logs neither in DevTools, nor on server side.

[dudanogueira]

Hi! I was not able to reproduce this issue =\

Can you get the infos from the user you created? When you edit a user, you can get that json from the network tab in browser developer tools, like so:

[IKrendelev]

Found out that this behavior was caused by "Omnichannel settings" menu availability, due to livechat-manager role that user actually has. This item makes [ ⁞ ] ("Administration") button visible along with "Workspace" item (that shouldn't be visible).

[dudanogueira]

Yep, that's true.

That's a good first issue for our #hacktoberfest :)

[nishant23122000]

@krenuser are you working on it?

[krenuser]

@krenuser are you working on it?

No, I haven't set up fully functional dev environment for that yet (I have a bit different dev specialization).
Maybe, some of my future bug reports...

[nishant23122000]

ok, can I work on that?

[krenuser]

ok, can I work on that?

Don't have any objections.

[mani-rsg]

Hi @nishant23122000 , is this issue being worked on? if not I could work on it, please confirm

[ankar84]

Found out that this behavior was caused by "Omnichannel settings" menu availability, due to livechat-manager role that user actually has. This item makes [ ⁞ ] ("Administration") button visible along with "Workspace" item (that shouldn't be visible).

Regular user with only user role don't have any administrations menu.
Guess that menu comes from bot or one of livechat roles, which is bug definitely.

[rksingh2001]

Can I take up this issue?

[Barrylimarti]

Hey @dudanogueira, the livechat manager role should offer the omnichannel option in the administration menu and not the workspace option right? Doing this is failing the unit test cases created for the AdministrationModelList as the test cases are searching for workspace option always and thus, I think the test case needs to be modified in order to solve this issue.

[dudanogueira]

hi @Barrylimarti! you are right!.

However, before that, there are failing tests that I am not sure it is related:
https://github.com/RocketChat/Rocket.Chat/actions/runs/3393376349/jobs/5640641602#step:42:6

I have pinged our good friend @filipemarins that can help us here :)