Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Showing Workspace Section For User Having LiveChat Manager Permission #27659

Closed
wants to merge 4 commits into from

Conversation

filipemarins
Copy link
Contributor

@filipemarins filipemarins commented Dec 28, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Closes #27081

oc-536

Steps to test or reproduce

Please refer #27081 for more details

  1. Log in as livechat-manager user (should not have admin role)
  2. Open Administration > Workspace menu item
    Screenshot 2022-12-27 at 11 12 35

Further comments

The Workspace menu shouldn't be visible since the livechat-manager user doesn't have any admin permission.

PR was created just to run the QA environment.

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #27659 (800bace) into develop (22ee46f) will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27659      +/-   ##
===========================================
+ Coverage    43.69%   44.22%   +0.53%     
===========================================
  Files          811      811              
  Lines        17166    17166              
  Branches      1901     1901              
===========================================
+ Hits          7501     7592      +91     
+ Misses        9412     9319      -93     
- Partials       253      255       +2     
Flag Coverage Δ
e2e 44.22% <ø> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 2, 2023
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jan 3, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jan 3, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Administration > Workspace is visible for usual users
3 participants