Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roles and permissions schema #292

Closed
vahid-sohrabloo opened this issue Jul 10, 2015 · 12 comments
Closed

Add roles and permissions schema #292

vahid-sohrabloo opened this issue Jul 10, 2015 · 12 comments

Comments

@vahid-sohrabloo
Copy link

I think we need role for user and access to action (like create channel) based on role.

@sampaiodiego
Copy link
Member

Yeah we need this.

This will define some implementations of #168 and #206

@vahid-sohrabloo
Copy link
Author

No milestone?

@engelgabriel engelgabriel added this to the v0.5 milestone Jul 19, 2015
@marceloschmidt marceloschmidt self-assigned this Jul 21, 2015
@marceloschmidt marceloschmidt changed the title Add Role Add roles and permissions schema Jul 27, 2015
@marceloschmidt marceloschmidt modified the milestones: v1.1, v0.5 Jul 27, 2015
@marceloschmidt marceloschmidt removed their assignment Jul 28, 2015
@rodrigok rodrigok modified the milestones: v1.1, Next Aug 15, 2015
@engelgabriel
Copy link
Member

@rwakida can you help with that?

@rwakida
Copy link
Contributor

rwakida commented Aug 19, 2015

@engelgabriel sure! @Sing-Li used restivus which in turn depends on alanning:meteor-roles. Is meteor-roles a good package to use? Do we have any documentation on what roles/permissions we'll need?

@Sing-Li
Copy link
Member

Sing-Li commented Aug 19, 2015

@rwakida - no documentation that i know of, but if you get it started with a PR or two, I'm sure all the stake-holders will chime in, or make mods to ensure everything works.

The only role that core currently uses, I think, is: [admin]

The extended roles used by REST APIs (that should only be created by an external, non-main-repo tool) are: [testagent, adminautomation]

Some other extended roles that will likely be required in the future: [configurator, provisioningagent]

The extended roles that you mentioned in another thread #455 may be: [botdelegate]

Permissions:

A starter set may be ['post-message', 'edit-message' , 'delete-message', 'create-public-room', 'create-private-room', 'read-all-messages']

Complete permissions set probably takes some thought/design, since the 'expressive-ness' of later 'policies' implementation will critically depend on them.

JMHO

@rwakida
Copy link
Contributor

rwakida commented Aug 22, 2015

Thanks @Sing-Li !

@lostwings211
Copy link

Hi Sing-Li,

I am very new to Meteor and Rocket.Chat, right now I am in the middle of a task to auto-provision Channel via REST bulk/createRoom API, however I am getting a "You do not have permission to do this." REST response.

Looks to me this would be role/permission related, so would you kindly let me know

  1. how to assign the [testagent, adminautomation] roles to a given user?
  2. which data store does that role/user association info gets persist to?

@Sing-Li
Copy link
Member

Sing-Li commented Sep 3, 2015

@lostwings211 Thanks for the questions. You will have to do this manually at this time. We will have some provisioning and management tools to get this done a little later - once the roles and permission system is in place. The package that we used is the well-known alanning:roles, the association is persisted into the user collection. If you need more details, please join the demo chat on the rocket.chat home page. Our team hangs out there most of the time. I'll be more than glad to help.

@marceloschmidt
Copy link
Member

@rwakida I'm interested in advancing into roles. Have you done anything on that topic? If so, may I continue your work? Thanks!

@rwakida
Copy link
Contributor

rwakida commented Sep 15, 2015

@marceloschmidt I'm almost done testing. I'll create a pull request within the next 24 hours...or at least push my branch if I feel it's not ready. Thanks.

@marceloschmidt
Copy link
Member

Thank you!

@rwakida
Copy link
Contributor

rwakida commented Sep 16, 2015

Hi @marceloschmidt . I created a pull request #818. Thanks!

@engelgabriel engelgabriel modified the milestone: Important Dec 6, 2016
Peym4n pushed a commit to redlink-gmbh/Rocket.Chat that referenced this issue Apr 6, 2018
…Adapt-assistify-toolbar

Adapt assistify room types' toolbars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants