Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email validation for new bot user not required #3818

Closed
timkinnane opened this issue Jul 20, 2016 · 3 comments
Closed

Email validation for new bot user not required #3818

timkinnane opened this issue Jul 20, 2016 · 3 comments

Comments

@timkinnane
Copy link
Contributor

Running #develop branch 0.35.0+

When creating user from admin interface, you must provide an email, or get the error "The field Email is required". Is this actually necessary for bot users though, do bots get notifications?

I notice Rocket.Cat has no email, so its obviously not breaking anything. I'd like to avoid having to invent arbitrary variations on email addresses for my small army of Hubots.

timkinnane pushed a commit to timkinnane/Rocket.Chat that referenced this issue Jul 21, 2016
- Disable requiring email when creating bot users from flex tab
- When bot selected disables verification, change password and welcome email fields
@timkinnane
Copy link
Contributor Author

Submitting PR now. This is part of some overhaul to UX and validation logic when manually creating new users as admin. This step addresses the different requirements when creating bot users, i.e. not requiring email address, password change or welcome email.

The UX side needs more work, the form could use more obvious validation states and visual indicators of required fields, also the field order should be changed to make dependent fields follow their parents and toggle entire display instead of just disable fields depending on context.

I will resolve the second part after @Ethaan's work on #3679 has been pulled into core.

@Rohlik
Copy link
Contributor

Rohlik commented Jan 28, 2017

Something new?

@timkinnane
Copy link
Contributor Author

Closing this in favor of #7125 to deal with the validation issue as part of more general update to bot user creation that may end up not requiring an email at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants