Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting the first message of a set (sometimes) also delete the avatar #415

Closed
Sing-Li opened this issue Aug 7, 2015 · 2 comments · May be fixed by timtheguy/Rocket.Chat#76, GOMYWAY-NETWORKS-LLC/Rocket.Chat#18 or qmutz/Rocket.Chat#35
Closed

Deleting the first message of a set (sometimes) also delete the avatar #415

Sing-Li opened this issue Aug 7, 2015 · 2 comments · May be fixed by timtheguy/Rocket.Chat#76, GOMYWAY-NETWORKS-LLC/Rocket.Chat#18 or qmutz/Rocket.Chat#35

Comments

@Sing-Li
Copy link
Member

Sing-Li commented Aug 7, 2015

This was an old bug, but back under some (not reliably reproducible) situations.

If you type two messages in rapid succession, and then delete the first one, sometimes the avatar next to the first message also disappears.

[Observed on Electron Mac app]

UPDATE: .... but after a few minutes, it fixes itself
@rodrigok
Copy link
Member

rodrigok commented Aug 7, 2015

@Sing-Li I made some changes to force re-render of messages around of the deleted message I hope that solve this problem :)

f012ee0

@rodrigok rodrigok closed this as completed Aug 7, 2015
@Sing-Li
Copy link
Member Author

Sing-Li commented Aug 7, 2015

As of 11 AM (UTC - 4) I am no longer fast enough to cause it to happen 😄

HappyTobi pushed a commit to HappyTobi/Rocket.Chat that referenced this issue Jul 10, 2018
@engelgabriel
Merge pull request RocketChat#415 from jszaszvari/patch-1
a41f62b 
Updated README with servers.json instructions
Shailesh351 added a commit to Shailesh351/Rocket.Chat that referenced this issue Oct 7, 2020
@github-actions @renatobecker
@ggazzo @sampaiodiego @mrtndwrd @wreiske @pierre-lehnen-rc @gabriellsh @alansikora @Shailesh351
[Upstream Catchup] Merge RC:master to develop_pwa (RocketChat#415)
6366f6c 
* [FIX] Omnichannel Current Chats open status filter not working (RocketChat#18795)

* [FIX][ENTERPRISE] Omnichannel service status switching to unavailable (RocketChat#18835)

* [FIX] File upload (Avatars, Emoji, Sounds) (RocketChat#18841)

* [FIX] IE11 support livechat widget  (RocketChat#18850)

* [FIX] Admin user blank page (RocketChat#18851)

* [FIX] User can't invite or join other Omnichannel rooms (RocketChat#18852)

* [FIX] Showing alerts during setup wizard (RocketChat#18862)

* Remember users' 2FA right after registration

* Change register server to false by default

* Bump version to 3.6.1

* [FIX] invite-all-from and invite-all-to commands don't work with multibyte room names (RocketChat#18919)

* [FIX] Create Custom OAuth services from environment variables (RocketChat#17377)

* [FIX] Read receipts showing blank names and not marking messages as read (RocketChat#18918)

* [FIX] Version update check cron job (RocketChat#18916)

* [FIX] Ignore User action from user card (RocketChat#18866)

* [FIX] Deactivate users that are the last owner of a room using REST API (RocketChat#18864)

* test: add e2e tests for REST API user deactivation

* fix(app): read confirmRelinquish from HTTP request

* chore(app): remove unnecessary console.log

* [FIX] Show custom fields of invalid type (RocketChat#18794)

* Bump version to 3.6.2

* [FIX] PDF not rendering (RocketChat#18956)

* [FIX] Errors in LDAP avatar sync preventing login (RocketChat#18948)

* [FIX] LDAP avatar upload (RocketChat#18994)

* [FIX] Federation issues (RocketChat#18978)

* fixed message sending, you should not filter the domains, specially filter by only the local origin/source

* Fixing callback registration

* Increased the rate limiting

* Obbey to settings properties (RocketChat#19020)

* Bump version to 3.6.3

* Update package-lock.json

Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Co-authored-by: Felipe Parreira <felipeparreirafb@gmail.com>
Co-authored-by: Maarten <me@maartendewaard.nl>
Co-authored-by: William Reiske <wreiske@mieweb.com>
Co-authored-by: pierre-lehnen-rc <55164754+pierre-lehnen-rc@users.noreply.github.com>
Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
Co-authored-by: Alan Sikora <alansikora@gmail.com>
Co-authored-by: Shailesh Baldaniya <shaileshbaldaniya351@gmail.com>
@snyk-bot snyk-bot mentioned this issue Jul 22, 2022
Open
@BMondly BMondly mentioned this issue Jul 22, 2022
Open
@wasimakh2 wasimakh2 mentioned this issue Jul 23, 2022
Open
@didierhk didierhk mentioned this issue Jul 23, 2022
Open
@srsamuka srsamuka mentioned this issue Jul 23, 2022
Open
@timtheguy timtheguy mentioned this issue Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Sing-Li @rodrigok