Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete all Attachments / Files from a Channel /Chat #6193

Closed
Angl0r opened this issue Feb 28, 2017 · 7 comments · Fixed by #11236
Closed

Delete all Attachments / Files from a Channel /Chat #6193

Angl0r opened this issue Feb 28, 2017 · 7 comments · Fixed by #11236
Labels
feat: channel settings Feature: Request Requested Feature

Comments

@Angl0r
Copy link

Angl0r commented Feb 28, 2017

Rocket.Chat Version: 0.52.0
Running Instances: 1
DB Replicaset OpLog: disabled
Node Version: V4.5.0

Hi there,

We would recoment a function wich eareses all Attachments in one Channel or Chat.

Example 1: a private chat between two Users got now more than 100 files uplaoded.
Example 2: a channel with more than 30 Users and a lot of files has been added to that channel.

Many of that files are no Longer used, but its hard work to delet them all single handed.
@danilomiranda
Copy link
Contributor

Where this function could be called? In here?
captura de tela 2017-06-09 as 2 31 25 pm

@marceloschmidt
Copy link
Member

I would suggest it on the attachments flextab.

@danilomiranda
Copy link
Contributor

@marceloschmidt Almost done, but I'm not like the style of delete all buttons

delete-files

@danilomiranda
Copy link
Contributor

How about that? 🤓
screenshot 2017-07-01 12 32 22

@danilomiranda
Copy link
Contributor

I think it`s done!

screenshot 2017-07-01 17 40 34

See this in action

@danilomiranda danilomiranda mentioned this issue Jul 1, 2017
Closed
@hikikomorime
Copy link

HI, Any date when this option will be available? It also be great to set some timeframe when attachments are purged automatically like after 7 days etc.

@imeleges
Copy link

imeleges commented Jun 5, 2018

Hi, I just upgraded my RC to version 0.65.1 and I don't see the ability to delete attachments from file list at all.
Did I miss something? =)
rc_filelist

@vynmera vynmera mentioned this issue Jul 9, 2018
Merged
42 tasks
ggazzo pushed a commit that referenced this issue Jul 20, 2018
@vynmera @ggazzo
[NEW][BREAK] Message retention policy and pruning (#11236)
829c5d1 
Closes #6749
Closes #8321
Closes #9374
Closes #2700
Closes #2639
Closes #2355 
Closes #1861
Closes #8757
Closes #7228
Closes #10870
Closes #6193 
Closes #11299
Closes #11468
Closes #9317
Closes #11300 (will incorporate a fix to this PR's issue)
Closes #11046 (will incorporate a fix to this PR's issue)
Contributes to #5944 
Contributes to #11475
_...and possibly more!_

This PR makes deleting messages (automatically and manually) a lot easier on Rocket.Chat.

- [X] Implement a bulk message deletion notification, to quickly push large message deletions to users without reload
  - [X] Use it in `rooms.cleanHistory`
  - [X] Use it in user deletions
- [X] Completely remove cleanChannelHistory as required by v0.67
  - [X] Remove server method `cleanChannelHistory`
  - [X] Remove REST API `channels.cleanHistory`
- [x] Implement a sidebar option to clean history
  - [x] Basic implementation
  - [x] Allow excluding pinned messages
  - [x] Allow attachment-only mode
  - [x] Allow specifying user(s) to narrow down to
    - [x] Also update REST API
    - [x] Also update docs
  - [x] Break the deletion into multiple different requests, so the client can keep track of progress
  - [x] Clear animation / progress bar for deleting
- [x] Retention policy
  - [X] Global, set by admin
    - [X] Global timer that runs every second and deletes messages over the set limit
      - [X] Can change its timer's resolution to prevent insane CPU overhead
    - [X] Admin can decide what room types to target (channels, groups and/or DMs)
    - [X] Allow excluding pinned messages
    - [X] Allow attachment-only mode
  - [x] Per-channel, set by those with a new permission
    - [x] Disabled when master switch off
    - [x] Set in channel info
    - [x] Can override global policy with a switch that requires `edit-privileged-setting`
    - [x] Allow excluding pinned messages
    - [x] Allow attachment-only mode
    - [x] Uses same global timer for cleanup
  - [X] Message at start of channel history / in channel info if there is a retention policy set
  - [x] Message in channel info if there is a retention policy set on that channel specifically
- [X] Make cleaning history also delete files (completely!)
  - [X] Manual purging
  - [X] Automatic purging
- [x] Make other deletions also delete files
  - [x] User deletion
    - [X] Own messages
    - [x] DMs with them's partner messages
  - [x] Room deletion
- [x] Cleanup
- [x] Finish related [docs](https://github.com/RocketChat/docs/pull/815)
- [x] Link to the docs in the settings

Please suggest any cool changes/additions! Any support is greatly appreciated.

**Breaking change:** This PR removes REST API endpoint `channels.cleanHistory` and Meteor callable `cleanChannelHistory` as per the protocol specified for them.

![bzzzzzzzz](https://user-images.githubusercontent.com/39674991/41799087-56d1dea0-7670-11e8-94c0-bc534b1f832d.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat: channel settings Feature: Request Requested Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NEW] Message retention policy and pruning vynmera/Rocket.Chat
6 participants
@danilomiranda @hikikomorime @marceloschmidt @Angl0r @imeleges @MartinSchoeler