Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing General Room to Private , doesnt stop new members from joining in #6403

Closed
IQ2022 opened this issue Mar 20, 2017 · 7 comments · Fixed by #6426
Closed

changing General Room to Private , doesnt stop new members from joining in #6403

IQ2022 opened this issue Mar 20, 2017 · 7 comments · Fixed by #6426

Comments

@IQ2022
Copy link

IQ2022 commented Mar 20, 2017

I have changed my general room default to Private from channel, however new registered users are still able to join that room?? is this by design?

thanks,

I

Rocket.Chat Version:
Running Instances:
DB Replicaset OpLog:
Node Version:

@TheReal1604
Copy link
Contributor

Hi @IQ2022,

i think the "default" setting in your room is persisting:

image

Can you check that in your admin settings?

@graywolf336
Copy link
Contributor

If you didn't set the default configuration setting on the room to false as TheReal mentioned, then yes that's working by design.

@ggazzo ggazzo self-assigned this Mar 21, 2017
@ggazzo
Copy link
Member

ggazzo commented Mar 21, 2017

@graywolf336 this option (channel ->private) shoud be disabled to default rooms?what do you think?

@localguru
Copy link
Contributor

I can confirm. After setting default to false, new users can access the room anymore.

@IQ2022
Copy link
Author

IQ2022 commented Mar 21, 2017

there is no where to change default to no default

@IQ2022
Copy link
Author

IQ2022 commented Mar 21, 2017

where to change default?
image

@ggazzo
Copy link
Member

ggazzo commented Mar 21, 2017

You can just change to default if the channel is public... there are a problem if you open the info channel that you dont subscribe, but I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment