Just admins can change a Default Channel to Private (the channel will be a non default channel) #6426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Mar 22, 2017
| if err | ||
| return handleError(err) | ||
| toastr.success TAPi18n.__ 'Room_type_changed_successfully' | ||
| func = => |
There was a problem hiding this comment.
could you please rename the func variable to anything else that makes more sense?
… admin you must confirm this
rodrigok
approved these changes
Mar 23, 2017
|
@sampaiodiego can you review again? |
sampaiodiego
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
closes #6403
For default channels,
I changed this methods to
RocketChat.ChannelSettings.addOptionRocketChat.ChannelSettings.getOptionsnow you can pass a filter, if you dont will return all options.