Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

direct messages received not displayed after login #723

Closed
homologus opened this issue Sep 7, 2015 · 7 comments
Closed

direct messages received not displayed after login #723

homologus opened this issue Sep 7, 2015 · 7 comments

Comments

@homologus
Copy link

Hello,

I recently installed rocket.chat in my server and was trying it on my own with two accounts. I noticed that often when one person (A) is logged out and another person (B) sends a direct message, that message does not show up on A's screen after A logs in. The message is not lost, because I can clearly see it in mongodb dump, it somehow never shows up on A's account.

I can reproduce this behavior very consistently. Did anyone else notice something similar?

@engelgabriel
Copy link
Member

can you give us the steps to reproduce?

@geekgonecrazy
Copy link
Contributor

Unable to produce.. :(

  1. I created two users userA and userB.
  2. I logged userB off.
  3. I sent a new message (none had been done before) from userA (still logged in) to userB (not logged in)
  4. I logged userB back in.

Message was waiting for it.

Did I miss any steps on this?

@homologus
Copy link
Author

Let me investigate more, because it seems like the behavior is more complicated than what I described.

Here are two screenshots and you can see the difference. The message marked in red does not show up in the other screen.

missing2
missing1

However, when I press browser reload on the second window, the missing messages comes back. So, it could be that the browser is not rendering the messages.

Hopefully, this is an isolated issue related to my browser setup and not a general problem of the program.

@Sing-Li Sing-Li changed the title losing direct messages, when not logged in direct messages received not displayed after login Sep 7, 2015
@rodrigok
Copy link
Member

rodrigok commented Sep 7, 2015

Seems that we don't reload the messages from opened rooms after login, you have the messages from before logout and after login. Probably the solution will be close all rooms in RoomManager on logout.

@homologus
Copy link
Author

Thanks rodrigok.

@Sing-Li
Copy link
Member

Sing-Li commented Sep 11, 2015

@homologus - can you please see if the problem has been fixed.

Might have been fixed by - e9d43e9

@homologus
Copy link
Author

Yes, it is. Thanks Sing-Li.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants