Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mention-all] permission does not work for roles other than "user" #8033

Closed
danieljhochman opened this issue Sep 4, 2017 · 1 comment · Fixed by #8931
Closed

[mention-all] permission does not work for roles other than "user" #8033

danieljhochman opened this issue Sep 4, 2017 · 1 comment · Fixed by #8931
Labels
feat: roles / permissions sponsored type: bug
Milestone
0.60.0

Comments

@danieljhochman
Copy link

RC Version:
Steps to reproduce:

  1. Remove [mention-all] permission from "user" role
  2. Enable [mention-all] permission for a different role such as "moderator" or "leader"
  3. Moderators or Leaders still cannot @ALL mention. They get a rocket.cat message that "Notify all in this room is not allowed"
@rebeld
Copy link

rebeld commented Oct 14, 2017 •
edited
Loading

@we just encountered this, our community is growing to the point where unfettered access to (at)all is becoming a nuisance so we tried to disable it for users and lost the ability for everyone. Any idea of a milestone for a fix for this?

sampaiodiego added a commit that referenced this issue Nov 23, 2017
@sampaiodiego
Check for mention-all permission in room scope
98df47b 
Closes #8033
@sampaiodiego sampaiodiego mentioned this issue Nov 23, 2017
Merged
geekgonecrazy pushed a commit that referenced this issue Dec 1, 2017
@sampaiodiego @geekgonecrazy
Check for mention-all permission in room scope (#8931)
9c34c10 
Closes #8033
@rodrigok rodrigok added this to the 0.60.0 milestone Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat: roles / permissions sponsored type: bug
Projects
None yet
Milestone
0.60.0
Development

Successfully merging a pull request may close this issue.

[FIX] Check for mention-all permission in room scope RocketChat/Rocket.Chat
5 participants
@rodrigok @rebeld @MartinSchoeler @danieljhochman @RamonNobre